From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752928AbcD0IfQ (ORCPT ); Wed, 27 Apr 2016 04:35:16 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:53424 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752189AbcD0IfN (ORCPT ); Wed, 27 Apr 2016 04:35:13 -0400 X-AuditID: cbfee690-f79056d000001327-fd-572079bf4d31 Message-id: <572079BE.9000006@samsung.com> Date: Wed, 27 Apr 2016 17:35:10 +0900 From: Jaehoon Chung User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: Enric Balletbo i Serra , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH v2 0/1] mmc: dw_mmc: Fix UHS tuning on some brand of cards. References: <1461657838-25484-1-git-send-email-enric.balletbo@collabora.com> In-reply-to: <1461657838-25484-1-git-send-email-enric.balletbo@collabora.com> Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrDLMWRmVeSWpSXmKPExsWyRsSkUHd/pUK4wedlLBZrbh9itLi8aw6b xZH//YwWx9eGO7B47Li7hNHjzrU9bB6fN8kFMEdx2aSk5mSWpRbp2yVwZdzf18xS8EugovfX CpYGxhW8XYycHBICJhIfDq5jgbDFJC7cW8/WxcjFISSwglGir+8yC0xR4+PPjBCJWYwSU479 g3IeMEosnvufFaSKV0BL4m/zJ3YQm0VAVWLC3F1gNpuAjsT2b8eZQGxRgTCJB+v2QtULSvyY fA9sg4jAHEaJ9d1BILawQITEle/LwHqFBHwkfh2/CFbPKeAr0fP2EtAcDg5mAXWJKVNyQcLM AvISm9e8ZQa5R0JgEbvE49832CBuEJD4NvkQC0i9hICsxKYDzBDPSEocXHGDZQKj6CwkV8xC mDoLydQFjMyrGEVTC5ILipPSi0z0ihNzi0vz0vWS83M3MQIj5fS/ZxN2MN47YH2IUYCDUYmH t0BCIVyINbGsuDL3EKMp0BETmaVEk/OB8ZhXEm9obGZkYWpiamxkbmmmJM77WupnsJBAemJJ anZqakFqUXxRaU5q8SFGJg5OqQbG1TFbFrdFbw6vXmwjb2LPf9hQu+5W7akf+8y6GKY5Zc5o truhZxHDL7zm1Mmj0QZHWOXqvlcenvZQn8NFbdpiFc9roYvXlcnMn/pNZeHaLSGB20v71680 TdZayWe01/SpddlkNVHOsptbu7VmsK563Tad7eu3+hPvc05cD56YrhV14ea3poNcSizFGYmG WsxFxYkAutpYXo8CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJIsWRmVeSWpSXmKPExsVy+t9jQd19lQrhBi/W2lisuX2I0eLyrjls Fkf+9zNaHF8b7sDisePuEkaPO9f2sHl83iQXwBzVwGiTkZqYklqkkJqXnJ+SmZduq+QdHO8c b2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RNSaEsMacUKBSQWFyspG+HaUJoiJuuBUxjhK5v SBBcj5EBGkhYw5hxf18zS8EvgYreXytYGhhX8HYxcnJICJhIND7+zAhhi0lcuLeerYuRi0NI YBajxJRj/xghnAeMEovn/mcFqeIV0JL42/yJHcRmEVCVmDB3F5jNJqAjsf3bcSYQW1QgTOLB ur1Q9YISPybfYwGxRQTmMEqs7w4CsYUFIiSufF8G1isk4CPx6/hFsHpOAV+JnreXgOZwcDAL qEtMmZILEmYWkJfYvOYt8wRG/llIps5CqJqFpGoBI/MqRonUguSC4qT0XMO81HK94sTc4tK8 dL3k/NxNjOBofCa1g/HgLvdDjAIcjEo8vAUSCuFCrIllxZW5hxglOJiVRHiNioBCvCmJlVWp RfnxRaU5qcWHGE2B3p7ILCWanA9MFHkl8YbGJmZGlkbmhhZGxuZK4ryP/68LExJITyxJzU5N LUgtgulj4uCUamBcbTj1/ubW4gtm5xun380x4b7U5RPCcqq0mFN9Y/6VffceXpILET6hV8RY 5WZ7UjtFoif4U/yqo/s3X3lsXnlkcetGp6mfvcu3eS+7kX0qkU1Vv+RluCqbzR2tMkP+Lr+k +WcPK6X2N878w8ZdO7dN+rqfCXfHookZVf9iJ8jEBkc53LgQflmJpTgj0VCLuag4EQDWw7dT 3AIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/26/2016 05:03 PM, Enric Balletbo i Serra wrote: > Hi, > > I introduced the cover letter to give some background about this. > > I have been investigating a problem related to at least one specific sdcard when > UHS-I is set. The card is not detected due the tuning phase reports a > failure. Since the problem is only reproduced with a single model of a single > brand of card, it is probably a card firmware issue, but the card works fine > on my laptop. I think you have analyzed many case..of course..it was successful to switch voltage, right? Maybe this patch too old..so can you remember which specific sdcard is produced? > > The first attempt to fix this was a patch sent by Doug Anderson [1], but Alim > Akhtar found that this produced randomly a hung task on Peach-pi. I can confirm > that it's easy to reproduce the hung task, either, with cold boots or suspend to > ram tests. Yep..I have already tested and checked for this. > > I tried to fix both problems (the original issue and the one introduced by the > patch) in different ways, but I ended thinking that this second proposal is the > most simple that solves both issues. So let's try to fix this by handling the > response CRC error slightly differently when tuning command is happening. > > I tested the patch on both platforms, on exynos and on rockhip. I did lots of > tests and at the moment the patch seems to fix the rockchip issue and don't > hung on exynos. I'll continue testing meanwhile we discuss about it. > > I think the patch, at least, needs the Doug's approval (as he dig into the issue > before) and the Tested-by Alim. So will be good if you have a slot of time to > look a bit into this. > > Thanks in advance. > Enric > > [1] https://lkml.org/lkml/2015/5/18/495 > > Changelog since v1: > - Fix the issue found by Alim with exynos letting the data transfer > take place only when MMC_SEND_TUNING_BLOCK is issued. > > Doug Anderson (1): > mmc: dw_mmc: Wait for data transfer after response errors. > > drivers/mmc/host/dw_mmc.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) >