From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbcD0Leg (ORCPT ); Wed, 27 Apr 2016 07:34:36 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:37497 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbcD0Lee (ORCPT ); Wed, 27 Apr 2016 07:34:34 -0400 Subject: Re: [PATCH] usb: dwc3: omap: get rid of dma_status To: References: <1460384305-21256-1-git-send-email-rogerq@ti.com> CC: , , From: Roger Quadros Message-ID: <5720A3C4.6030506@ti.com> Date: Wed, 27 Apr 2016 14:34:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1460384305-21256-1-git-send-email-rogerq@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Felipe, On 11/04/16 17:18, Roger Quadros wrote: > dma_status bit flag is set but never really used > so get rid of it. > > Reported-by: Felipe Balbi > Signed-off-by: Roger Quadros Gentle ping on this one for -next. Thanks. cheers, -roger > --- > drivers/usb/dwc3/dwc3-omap.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c > index 55da2c7..890b8a6 100644 > --- a/drivers/usb/dwc3/dwc3-omap.c > +++ b/drivers/usb/dwc3/dwc3-omap.c > @@ -126,8 +126,6 @@ struct dwc3_omap { > u32 debug_offset; > u32 irq0_offset; > > - u32 dma_status:1; > - > struct extcon_dev *edev; > struct notifier_block vbus_nb; > struct notifier_block id_nb; > @@ -277,9 +275,6 @@ static irqreturn_t dwc3_omap_interrupt(int irq, void *_omap) > > reg = dwc3_omap_read_irqmisc_status(omap); > > - if (reg & USBOTGSS_IRQMISC_DMADISABLECLR) > - omap->dma_status = false; > - > dwc3_omap_write_irqmisc_status(omap, reg); > > reg = dwc3_omap_read_irq0_status(omap); > @@ -504,7 +499,6 @@ static int dwc3_omap_probe(struct platform_device *pdev) > > /* check the DMA Status */ > reg = dwc3_omap_readl(omap->base, USBOTGSS_SYSCONFIG); > - omap->dma_status = !!(reg & USBOTGSS_SYSCONFIG_DMADISABLE); > > ret = devm_request_irq(dev, omap->irq, dwc3_omap_interrupt, 0, > "dwc3-omap", omap); >