From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753673AbcD0S4n (ORCPT ); Wed, 27 Apr 2016 14:56:43 -0400 Received: from mail-lf0-f51.google.com ([209.85.215.51]:34066 "EHLO mail-lf0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753213AbcD0S4k (ORCPT ); Wed, 27 Apr 2016 14:56:40 -0400 Subject: Re: [PATCH 1/3] lightnvm: do not free unused metadata on rrpc To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= References: <1461778138-23116-1-git-send-email-javier@javigon.com> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <57210B65.5020800@bjorling.me> Date: Wed, 27 Apr 2016 20:56:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461778138-23116-1-git-send-email-javier@javigon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/27/2016 07:28 PM, Javier González wrote: > rrpc does not save any metadata on a given request. Thus, do not attempt > to free the metadata dma region. > > Signed-off-by: Javier González > --- > drivers/lightnvm/rrpc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/lightnvm/rrpc.c b/drivers/lightnvm/rrpc.c > index c7fef71..ffcfee6 100644 > --- a/drivers/lightnvm/rrpc.c > +++ b/drivers/lightnvm/rrpc.c > @@ -711,8 +711,6 @@ static void rrpc_end_io(struct nvm_rq *rqd) > > if (npages > 1) > nvm_dev_dma_free(rrpc->dev, rqd->ppa_list, rqd->dma_ppa_list); > - if (rqd->metadata) > - nvm_dev_dma_free(rrpc->dev, rqd->metadata, rqd->dma_metadata); > > mempool_free(rqd, rrpc->rq_pool); > } > Thanks. Applied for 4.7.