From: "Matias Bjørling" <mb@lightnvm.io>
To: "Javier González" <jg@lightnvm.io>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
"Javier González" <javier@cnexlabs.com>
Subject: Re: [PATCH 2/3] lightnvm: enable metadata to be sent to device
Date: Thu, 28 Apr 2016 15:47:42 +0200 [thread overview]
Message-ID: <5722147E.8090006@lightnvm.io> (raw)
In-Reply-To: <1461778138-23116-2-git-send-email-javier@javigon.com>
On 04/27/2016 07:28 PM, Javier González wrote:
> Enable metadata to be sent to the device through the metadata field on
> the physical rw nvme command. When a single ppa is sent to the device, a
> 64-bit integer can be sent as metadata; when a ppa list is sent, a
> 64-bit integer list mapping to the ppa list can be used to send
> metadata.
>
> Signed-off-by: Javier González <javier@cnexlabs.com>
> ---
> drivers/nvme/host/lightnvm.c | 1 +
> include/linux/lightnvm.h | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index b1a0d8b..92da28d 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -467,6 +467,7 @@ static inline void nvme_nvm_rqtocmd(struct request *rq, struct nvm_rq *rqd,
> c->ph_rw.opcode = rqd->opcode;
> c->ph_rw.nsid = cpu_to_le32(ns->ns_id);
> c->ph_rw.spba = cpu_to_le64(rqd->ppa_addr.ppa);
> + c->ph_rw.metadata = cpu_to_le64(rqd->meta_list);
> c->ph_rw.control = cpu_to_le16(rqd->flags);
> c->ph_rw.length = cpu_to_le16(rqd->nr_pages - 1);
>
> diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h
> index 1e3b53e..9768bae 100644
> --- a/include/linux/lightnvm.h
> +++ b/include/linux/lightnvm.h
> @@ -239,8 +239,8 @@ struct nvm_rq {
>
> struct ppa_addr *ppa_list;
>
> - void *metadata;
> - dma_addr_t dma_metadata;
> + void *meta_list;
> + dma_addr_t dma_meta_list;
>
> struct completion *wait;
> nvm_end_io_fn *end_io;
>
Thanks Javier. Applied for 4.7.
next prev parent reply other threads:[~2016-04-28 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 17:28 [PATCH 1/3] lightnvm: do not free unused metadata on rrpc Javier González
2016-04-27 17:28 ` [PATCH 2/3] lightnvm: enable metadata to be sent to device Javier González
2016-04-28 13:47 ` Matias Bjørling [this message]
2016-04-27 17:28 ` [PATCH 3/3] lightnvm: rename dma helper functions Javier González
2016-04-27 18:54 ` Matias Bjørling
2016-04-27 20:17 ` Javier González
2016-04-27 18:56 ` [PATCH 1/3] lightnvm: do not free unused metadata on rrpc Matias Bjørling
2016-04-28 13:41 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5722147E.8090006@lightnvm.io \
--to=mb@lightnvm.io \
--cc=javier@cnexlabs.com \
--cc=jg@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox