From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753155AbcD1Nrs (ORCPT ); Thu, 28 Apr 2016 09:47:48 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:37707 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753103AbcD1Nrp (ORCPT ); Thu, 28 Apr 2016 09:47:45 -0400 Subject: Re: [PATCH 2/3] lightnvm: enable metadata to be sent to device To: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= References: <1461778138-23116-1-git-send-email-javier@javigon.com> <1461778138-23116-2-git-send-email-javier@javigon.com> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, =?UTF-8?Q?Javier_Gonz=c3=a1lez?= From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <5722147E.8090006@lightnvm.io> Date: Thu, 28 Apr 2016 15:47:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1461778138-23116-2-git-send-email-javier@javigon.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/27/2016 07:28 PM, Javier González wrote: > Enable metadata to be sent to the device through the metadata field on > the physical rw nvme command. When a single ppa is sent to the device, a > 64-bit integer can be sent as metadata; when a ppa list is sent, a > 64-bit integer list mapping to the ppa list can be used to send > metadata. > > Signed-off-by: Javier González > --- > drivers/nvme/host/lightnvm.c | 1 + > include/linux/lightnvm.h | 4 ++-- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c > index b1a0d8b..92da28d 100644 > --- a/drivers/nvme/host/lightnvm.c > +++ b/drivers/nvme/host/lightnvm.c > @@ -467,6 +467,7 @@ static inline void nvme_nvm_rqtocmd(struct request *rq, struct nvm_rq *rqd, > c->ph_rw.opcode = rqd->opcode; > c->ph_rw.nsid = cpu_to_le32(ns->ns_id); > c->ph_rw.spba = cpu_to_le64(rqd->ppa_addr.ppa); > + c->ph_rw.metadata = cpu_to_le64(rqd->meta_list); > c->ph_rw.control = cpu_to_le16(rqd->flags); > c->ph_rw.length = cpu_to_le16(rqd->nr_pages - 1); > > diff --git a/include/linux/lightnvm.h b/include/linux/lightnvm.h > index 1e3b53e..9768bae 100644 > --- a/include/linux/lightnvm.h > +++ b/include/linux/lightnvm.h > @@ -239,8 +239,8 @@ struct nvm_rq { > > struct ppa_addr *ppa_list; > > - void *metadata; > - dma_addr_t dma_metadata; > + void *meta_list; > + dma_addr_t dma_meta_list; > > struct completion *wait; > nvm_end_io_fn *end_io; > Thanks Javier. Applied for 4.7.