From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753549AbcD1VIK (ORCPT ); Thu, 28 Apr 2016 17:08:10 -0400 Received: from mail-bn1on0136.outbound.protection.outlook.com ([157.56.110.136]:60483 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753070AbcD1VII (ORCPT ); Thu, 28 Apr 2016 17:08:08 -0400 Authentication-Results: linux.vnet.ibm.com; dkim=none (message not signed) header.d=none;linux.vnet.ibm.com; dmarc=none action=none header.from=hpe.com; Message-ID: <57227BAA.7040807@hpe.com> Date: Thu, 28 Apr 2016 17:07:54 -0400 From: Waiman Long User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130109 Thunderbird/10.0.12 MIME-Version: 1.0 To: Pan Xinhui CC: , , , , Boqun Feng , Paul Mackerras , "Paul E. McKenney" , Michael Ellerman , , , , , , , , Subject: Re: [PATCH resend] powerpc: enable qspinlock and its virtualization support References: <5721EC0E.8040506@linux.vnet.ibm.com> In-Reply-To: <5721EC0E.8040506@linux.vnet.ibm.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [72.71.243.37] X-ClientProxiedBy: BY2PR06CA024.namprd06.prod.outlook.com (10.141.250.142) To CS1PR84MB0309.NAMPRD84.PROD.OUTLOOK.COM (10.162.189.158) X-MS-Office365-Filtering-Correlation-Id: 8e7bb280-7654-4f82-cdab-08d36fa930bb X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0309;2:cnf8UiKP7J1/aYM1/UoIQvRigAitqHpIRuA5oKxbdbcPuJcofZyoRoI58675F4ze+wrEoEPMccSmr1skQS7MT8RkAoPya03FvXJnaKFuuemvqRjOnrlWT+7YIvD41zcEm2Y2ZY9HuMBaDsyAcenVFkFNd0vUzg0EzDKdHSsf26bfrOw4UjpXY+scl9SUzQzM;3:WycJBxhe4KCNRvOX+50mdxTsDy5Y2uoP9MOzJEiGPHViVn9+v2KzcqdnjISrMpxs4BNGXZx35e/ewOmALkPFZ1h7gTq7MfcmO3M92iA2UE5L/yX0Fmc2l5yOGTrwS/F/;25:AQQ+8/lyScxcb6xE+UZuDdOBbKSnO61vEUgVhzuhaf4Pbl6QYaDpaGDuiBHcm/xfL48lZEsxj/S5nX5apQUzR1tC00yoHeZsXwRk8adzp1AO45sLOrgkNIuxU26limampb1WxnaHCjIIqBjrJa26WdOXTD/QmSfDg0Zn3FXq1sudkWL3JeEwj2gEH/1tMixsF8+DTosNc+iibsp+LUvKB6g91/rWJZPYVmm3oo8AW2VOJ3jGF+O5UVainSsc1Pgre5LjE4cMUMJvyMs3TkllmDpTfZmmqCF9jTW35h2di0U3E8jtsiz6xlzb+gqCyjiJ2q5Fnyh19UgsIA/9UmltvA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0309; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0309;20:9HvQIEm/9b14OkMb15STBaIk9AVu8PLE6iY+npZfIhFl+dxvAdLXbn3BBYRqoj/ZTBce4vDr7YTA+9T3FYb8v3mFqPoXIxA1sencSGRSZDbiWLrxLg0bR6RvPLcU1y/T/Ki1XTzCI7gDhachz+dN1n/K9v39RNdtCoynRTmxddViX6tEJmgPn4lxTv/Edk3NQVmRv6kHZKFmY+hO22TubkNVvQbwyF8qLBJjNUZiAka4vMxtIPSQdlJ2YP+bJq7lduUXDUx8O1mKW0rIUpgkIDKyMVZJa8o8EF4rwP/aI0JJ5xOyMpxza+3OhwzcwFMIhHFuJVE1ebgoFZVg/W63wQ==;4:EgDL7vmwiF0KOCBcVzoM12KdRsYCJl1HZSHvZ8D317/IsBVh+JMt5DMUojAXSM+3Wb9QTQzbOqoW1c21X3jmQlvmTTa2+pbteft/o1p7m4iCM14/sw1/YYFM8psyC1HATs1Te++l8Y8JLhB9tp0muWnsk08pgNOcPuF3gNmsyyiK2fHsm3eq56PRKfBV8s12nS7oG1O4YN2bibJPRz8o27wxSYx+qAGzdlqD8rEJjk/s+t3jBRnyb5BUiipXbd/iN++Qtyc08Q9IvmoeqcV82UHX2zs7cDOyCfyPEhpbUtfpBSxLe5Vtknk+3IiafLREJnvnvpPe2/3Lbz+I/LdEgRJtTgdHT27Dv/q3kTzJOUKcBHXUEKgGB9YRPiSkEUmb X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001);SRVR:CS1PR84MB0309;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0309; X-Forefront-PRVS: 0926B0E013 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(377454003)(24454002)(33656002)(2950100001)(65956001)(65806001)(77096005)(66066001)(47776003)(42186005)(36756003)(81166005)(230700001)(50986999)(76176999)(87266999)(64126003)(4326007)(2906002)(4001350100001)(23676002)(5008740100001)(50466002)(59896002)(117156001)(54356999)(5004730100002)(19580405001)(80316001)(586003)(110136002)(1096002)(92566002)(3846002)(86362001)(65816999)(6116002)(19580395003)(83506001)(189998001);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0309;H:[192.168.142.163];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtDUzFQUjg0TUIwMzA5OzIzOisrMjBIM1RjREVCUDF5Uit0bUxBUGZ6VGhK?= =?utf-8?B?NFc4NTIzUVh0U1BBbEVSaG0vQ1ZZSHE5SGd2ajRBdUZLMkljSzIxV1pYUkZa?= =?utf-8?B?a0Z2ekxLaVhSWFFvWms0cXJoQktWYk12VVFMY2UweHJsWTZnbVRkUTl1aHV2?= =?utf-8?B?MUN0Z3NJMUYrT1ZTRWFtbDNYR2ptVDI4TWhqWnN0TGxHdGJPQ3g3TGF1MWdY?= =?utf-8?B?MVlkWmxVNTZHYjBaWG96VjNGUTlpUWlYQm5QeFhLNlNMZlc3Ni9IcnpWSVB0?= =?utf-8?B?eUhEdmUxdmRKU3UrUVNWZVhqVWRMRGhxRWR6TnY3V3Z5WDMzaEs5V0xZbW1i?= =?utf-8?B?a3RXY0R0elhkczVuOHczVi9RWTFLejE3ekhTYkpUellVTFo1WTdsL0ZmV0Vu?= =?utf-8?B?TC9JZTcwcjBMNkUwMk1iVXh6TmxIbXpRL2JTRXVNZU9BSXpPKytuUTNIOEdW?= =?utf-8?B?bElQNXM2bkFoNjJOQ0pvSTcyQUwxWmNyclpmV0IxRStEbUZoUFo0NVVlOGF5?= =?utf-8?B?UlFUK3EvSHFNT3Zqc1M2K3ZxSmVZcU5GbmJMejRPbitnQlJ3dzdGLzh2QkJn?= =?utf-8?B?T0kyQTBmQ2hnNFdNTHBVWlcvOXJ6N0s0NVFoRnNJR20xdUlZYWJvMTllZGlt?= =?utf-8?B?NXFURmJPdTN6RnNYRnNGcjh5a2t3Ynlka21vVEI5VEY2VWc0UUNOUkp2Rllv?= =?utf-8?B?Qk8xWWh0SHFhbWg2YXZIRWlVMUhUZEtwaHJRdThqZXNmd3ExR1BvTkJZUVEw?= =?utf-8?B?YzcyMnJRNjNlV0JBYWJxTkJaVERjYkJZc1NpWGxUODFRNDMvZ3hkY004SDhr?= =?utf-8?B?N2t5b1phME5RUVNEZysxWitDN1VYbXdHM0t1U2NYOTBmb3dEeUlKUzJJRVJF?= =?utf-8?B?TG1oNzhiVDNzekRqcmR3dCtQN2NwNkUrTDVMVm9VQkpCUnZyQ21Bd3VzY0pO?= =?utf-8?B?cnhZbkU4dWJobWQ1anVhdUtsUUxISys4MGpVVnRhWnNUaXFaVUd2bnFVYm4v?= =?utf-8?B?THF1dUJMMjY0VHg3S1FlSWJaVTcyK3IxT0hpNS9rcVFxc3RuelJGODZrM3po?= =?utf-8?B?bjdIMjNkUEcwMWY0dVJyRTJkYVZVM0ZBdGxGckk1dWpsN1VOTVhFVmpLK3BC?= =?utf-8?B?YUtZRm92L0ZzTGJ4TGw0Q09sWGt3VzVYSE5OVlRHNjVObE1PTjJuWDlhRFBO?= =?utf-8?B?cHE4elZiM205NHhkOFBPR2NJM2o3dTZVaWJRMjBJOWdheWUwcU9UVkRsMTdW?= =?utf-8?B?Qkh4YTc0bnFDVm1YVVRVd0hCclhQT1NsVHFjZW9aZ0doMzg4b3ZZeFlsK1NN?= =?utf-8?B?bWJmNHJtS2NVNmVvSXdaZ0k0aHFCckNpT09DamFib1BHMW54VU42cWl6ZWMy?= =?utf-8?B?NlQxR3RKc1FaMVo4KzlSYlZabGN0cERjMmpGQURyTGE3dzRiQWEvYWxxYlpR?= =?utf-8?B?bUVmazZRN0pBdzlRcSthRWNubkJoVEFxeFMzbm5KZ3YxNUpTYVNvSS9YOHYz?= =?utf-8?Q?BhBAG/celGla1eNKwIiQBNPgQ=3D?= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0309;5:akqOLsfIk727GU2XFKefveQ0u9cfglIr2c8qH/Zan/5HdmYoAV68nCUhYx9NLuEhoiagFuxdfVv+nvGqlYdfq2trT5J/D/uJDMcIFGgLoKLCW9wXJhZ+cQrcRL52CvZSM7EaGq9gbNDO7MuZ9ttzHQ==;24:xtStLsWfr5B3wuW7R1vbiGeg4DmTqh9IfmeH/OLbLjPeGrmhdpzB2u7npcqXvpSAFqlFxbzDutvE0SDs5gRb7lXCV6kwfvh9jYTC4qZLXoc=;7:ry2FILKIAWHuFRUTYe8QV+Bn1QXn0zzT9cqAGX6AYrbAwSRynNtj90N6wnQ85qWViiEQMBRa9vlBIckZTgjGM5c9VXqnAqTdXe471K/y3/htEkmUji2GiwclXWxJ+itfs3qrG/exSrnPqbhmx3zLY5Uo8VlN8lA2DTLb6TTdR2zTARiylFYzLXQGsnh7l/a0 SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2016 21:08:03.7610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0309 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/28/2016 06:55 AM, Pan Xinhui wrote: > From: Pan Xinhui > > This patch aims to enable qspinlock on PPC. And on pseries platform, it also support > paravirt qspinlock. > > Signed-off-by: Pan Xinhui > --- > arch/powerpc/include/asm/qspinlock.h | 37 +++++++++++++++ > arch/powerpc/include/asm/qspinlock_paravirt.h | 36 +++++++++++++++ > .../powerpc/include/asm/qspinlock_paravirt_types.h | 13 ++++++ > arch/powerpc/include/asm/spinlock.h | 31 ++++++++----- > arch/powerpc/include/asm/spinlock_types.h | 4 ++ > arch/powerpc/kernel/paravirt.c | 52 ++++++++++++++++++++++ > arch/powerpc/lib/locks.c | 32 +++++++++++++ > arch/powerpc/platforms/pseries/setup.c | 5 +++ > 8 files changed, 198 insertions(+), 12 deletions(-) > create mode 100644 arch/powerpc/include/asm/qspinlock.h > create mode 100644 arch/powerpc/include/asm/qspinlock_paravirt.h > create mode 100644 arch/powerpc/include/asm/qspinlock_paravirt_types.h > create mode 100644 arch/powerpc/kernel/paravirt.c > > This is just an enablement patch. You will also need a patch to activate qspinlock for, at lease, some PPC configs. Right? It has dependency on the pv_wait() patch that I sent out extend the parameter list. Some performance data on how PPC system will perform with and without qspinlock will also be helpful data points. Cheers, Longman