From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753065AbcD2JbR (ORCPT ); Fri, 29 Apr 2016 05:31:17 -0400 Received: from foss.arm.com ([217.140.101.70]:49650 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbcD2JbP (ORCPT ); Fri, 29 Apr 2016 05:31:15 -0400 Subject: Re: [PATCH v2 1/2][UPDATE] PM / OPP: add non-OF versions of dev_pm_opp_{cpumask_,}remove_table To: Viresh Kumar References: <1461863237-12928-1-git-send-email-sudeep.holla@arm.com> <1461921756-15109-1-git-send-email-sudeep.holla@arm.com> <20160429092825.GA17472@vireshk-i7> Cc: Sudeep Holla , linux-kernel@vger.kernel.org, Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , linux-pm@vger.kernel.org From: Sudeep Holla Organization: ARM Message-ID: <572329DF.2060209@arm.com> Date: Fri, 29 Apr 2016 10:31:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160429092825.GA17472@vireshk-i7> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/04/16 10:28, Viresh Kumar wrote: > This isn't V2, but V3 > > On 29-04-16, 10:22, Sudeep Holla wrote: >> Functions dev_pm_opp_of_{cpumask_,}remove_table removes/frees all the >> static OPP entries associated with the device and/or all cpus(in case >> of cpumask) that are created from DT. >> >> However the OPP entries are populated reading from the firmware or some >> different method using dev_pm_opp_add are marked dynamic and can't be >> removed using above functions. >> >> This patch adds non DT/OF versions of dev_pm_opp_{cpumask_,}remove_table >> to support the above mentioned usecase. >> >> This is in preparation to make use of the same in scpi-cpufreq.c >> >> Cc: Viresh Kumar >> Cc: Nishanth Menon >> CC: Stephen Boyd >> Cc: "Rafael J. Wysocki" >> Cc: linux-pm@vger.kernel.org >> Signed-off-by: Sudeep Holla >> --- >> drivers/base/power/opp/core.c | 56 ++++++++++++++++++++++++++++++---------- >> drivers/base/power/opp/cpu.c | 59 ++++++++++++++++++++++++++++++++----------- >> include/linux/pm_opp.h | 10 ++++++++ >> 3 files changed, 96 insertions(+), 29 deletions(-) >> >> v1->v2: >> - Instead of renaming OF versions, created non-OF versions of >> dev_pm_opp_{cpumask_,}remove_table as suggested by Viresh >> > > You should have added v2->v3 here > No, thought I will post v3 of both the patches with your ACK so that it's easy for Rafael to pick up if he has no comments :) >> This version also updates all the errors in documentation and changes >> to use remove_all rather than remove_dyn. > > But all that isn't going to be part of the history, so it should be fine :) > > Acked-by: Viresh Kumar > Thanks -- Regards, Sudeep