From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753452AbcD2Ox6 (ORCPT ); Fri, 29 Apr 2016 10:53:58 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:36778 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753638AbcD2Ox4 (ORCPT ); Fri, 29 Apr 2016 10:53:56 -0400 Subject: Re: [GIT PULL] move ARM LCD display driver to auxdisplay To: Maxime Ripard , Linus Walleij References: <20160425115758.GA4874@lukather> <20160428092608.GE17159@lukather> CC: Robin van der Gracht , "arm@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Miguel Ojeda Sandonis From: Tomi Valkeinen Message-ID: <5723755D.9060108@ti.com> Date: Fri, 29 Apr 2016 17:53:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160428092608.GE17159@lukather> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="eitlkprm4w38VhMSm1Amlfhpg9t3NoWk2" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --eitlkprm4w38VhMSm1Amlfhpg9t3NoWk2 Content-Type: multipart/mixed; boundary="fIJAnJAXkB4lQ2XhTU8v5CRfkvdl0X9jG" From: Tomi Valkeinen To: Maxime Ripard , Linus Walleij Cc: Robin van der Gracht , "arm@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Miguel Ojeda Sandonis Message-ID: <5723755D.9060108@ti.com> Subject: Re: [GIT PULL] move ARM LCD display driver to auxdisplay References: <20160425115758.GA4874@lukather> <20160428092608.GE17159@lukather> In-Reply-To: <20160428092608.GE17159@lukather> --fIJAnJAXkB4lQ2XhTU8v5CRfkvdl0X9jG Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 28/04/16 12:26, Maxime Ripard wrote: > On Tue, Apr 26, 2016 at 12:41:29PM +0200, Linus Walleij wrote: >> On Mon, Apr 25, 2016 at 1:57 PM, Maxime Ripard >> wrote: >>> On Sat, Apr 23, 2016 at 11:43:58AM +0200, Linus Walleij wrote: >>>> Hi ARM SoC guys, >>>> >>>> these two patches move the ARM character LCD driver from >>>> misc drivers to the auxdisplay subsystem where it belongs and >>>> updates the defconfig for the RealView accordingly. >>>> >>>> Please pull it into some cleanup branch in the ARM SoC >>>> tree. >>>> >>>> I tried to get some ACK from the auxdisplay maintainer but no >>>> reaction. >>> >>> Auxdisplay is not a new framework, but rather a very old one. >>> >>> It got introduced in 2.6.21, and only received a couple of drivers >>> since. >> >> Small problem for me, but Robin is submitting a brand new >> auxdisplay driver: >> http://marc.info/?l=3Dlinux-kernel&m=3D146001950512999&w=3D2 >> http://marc.info/?l=3Dlinux-kernel&m=3D146001988013230&w=3D2 >=20 > My understanding is that Tomi doesn't want any new fbdev drivers, so > I'm not sure this is the right place for those patches. Hmm, that one looks like an fbdev driver, not an auxdisplay driver. But, not relevant for this patch, of course. >>> It seems to be quite redundant with fbdev deferred_io, which itself i= s >>> almost deprecated these days. >> >> That is a valid argument for moving cfag12864b* out to >> drivers/video/* I guess, but it has nothing to do with this >> driver whatsoever. >> >> This driver has nothing to do with fbdev. Nothing at all. >> It so not connected to any framebuffer. >> >> This driver gets moved to auxdisplay to match the existing >> LCD driver in drivers/auxdisplay/ks0108.c which is a similar >> hardware, driving an LCD that likewise has nothing to do >> with fbdev. >=20 > My bad, I thought all auxdisplay drivers were fbdev ones, but I was > wrong, obviously. And now, I don't really know what auxdisplay is > about anymore :) >=20 > Still, moving it to a "framework" that has been inactive for so long > (and you even mention it in your PR) doesn't seem like the right move. I think this move makes sense. It's only moving a file to a directory that at least mentions "display", not really moving it into a framework (because there doesn't seem to be any). Tomi --fIJAnJAXkB4lQ2XhTU8v5CRfkvdl0X9jG-- --eitlkprm4w38VhMSm1Amlfhpg9t3NoWk2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXI3VdAAoJEPo9qoy8lh71HRgQAICWwZW03yxSsegcELNUaxIR iTJcmHH36GDVLBG6tNtiISiYqULhA+fANT4A3t+cuQSqikR9QAp/ehvLkszXBK1N EryMMNUn/7KBxj/KVZBah4EnJs9/zkinS69CnfJeYtSa5CzGEIwfmsJXG/sdiA0f 5eBC/pT4yuD+YBcaGf+H4ZvQUW0yfi4de/UhjAza9kz+nlj5llofjqMn/hvi3dNd VJa7YAv7YL6MliI2f4JiolcSYsvsHAWHGraMm8zyS+ytxi7zLJ4xWg6hKrt6o37c j604VWkzo0AF44nHHWRAR32w4NGTE3hY6AN64tpKuOD+qa1lDh/n2fZRLY2A1nlu AmPekG/ambGsmXQvSyjMA25UIQWdAnUzH3Chmslsokblrnn8nRGO8x9NvF9tLCza zzLoUphYE+YV916t7mYHKKHI0omgpbOXiyTR0QSxOq/eLIiDiFtz5+c/iToro9cB w66+iFuEYh0lU860jAmiwG0cE2fTzRL+NeFl0UH0+rBWUm44A1VkSt/PR//IMYTE 9S0cJ49YatteaTN8LTaHddajLG9omfcn8qPdTUmnp6p2o28dJkX/yK8dmePiTtli e+lY0+wBoEhDQp/o7B7y7hBp2Z4xeylZshcn4vIaxZE95mw/xz7BXHkYli4niLrV nWo6wXv2XXSh/i8reOOU =BDdm -----END PGP SIGNATURE----- --eitlkprm4w38VhMSm1Amlfhpg9t3NoWk2--