From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751301AbcEAG3N (ORCPT ); Sun, 1 May 2016 02:29:13 -0400 Received: from mxout1.netvision.net.il ([194.90.9.20]:47486 "EHLO mxout1.netvision.net.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750789AbcEAG3M (ORCPT ); Sun, 1 May 2016 02:29:12 -0400 MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII; format=flowed Message-id: <5725A1F4.20606@gmail.com> Date: Sun, 01 May 2016 09:28:04 +0300 From: Eli Billauer User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7 To: Sudip Mukherjee Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] char: xillybus: use devm_add_action_or_reset References: <1462032800-24783-1-git-send-email-sudipm.mukherjee@gmail.com> In-reply-to: <1462032800-24783-1-git-send-email-sudipm.mukherjee@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fine with me. Thanks. Acked-by: Eli Billauer On 30/04/16 19:13, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling dma_unmap_single(), > pci_unmap_single() and kfree(). Lets use the helper > devm_add_action_or_reset() and return directly in case of error, as we > know that the cleanup function has been already called by the helper if > there was any error. At that same time remove the variable rc which > becomes unused now. > > Signed-off-by: Sudip Mukherjee > --- > >