Re: [RESEND PATCH v3 2/2] ARM: multi_v7_defconfig: Enable Samsung media platform drivers as modules

Re: [RESEND PATCH v3 2/2] ARM: multi_v7_defconfig: Enable Samsung media platform drivers as modules

[Javier Martinez Canillas]

On 04/25/2016 12:51 PM, Javier Martinez Canillas wrote:
> There are a bunch of media platform drivers under drivers/media/platform/
> for Samsung SoCs that are enabled in exynos_defconfig but no in multi_v7.
> 
> This patch enables them as a module to improve build coverage for these
> drivers and also to allow people use them with proper hardware if modules
> are installed.
> 
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> Hello,
> 
> I'm resending the patches because Krzysztof pointed out that they didn't
> end in patchwork. Sorry for the noise.
>

...and I see the patches didn't make it to LKML again, since are neither
in the archives nor in patchwork. I wonder what I'm doing wrong for these
since I post them just like all the other patches that make to the lists.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[RESEND PATCH v3 2/2] ARM: multi_v7_defconfig: Enable Samsung media platform drivers as modules

[Javier Martinez Canillas]

There are a bunch of media platform drivers under drivers/media/platform/
for Samsung SoCs that are enabled in exynos_defconfig but no in multi_v7.

This patch enables them as a module to improve build coverage for these
drivers and also to allow people use them with proper hardware if modules
are installed.

Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>

---
Hello,

I'm resending the patches because Krzysztof pointed out that they didn't
end in patchwork. Sorry for the noise.

Best regards,
Javier

Changes in v3: None
Changes in v2: None

 arch/arm/configs/multi_v7_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 7a4531c0eadb..253c8edf703b 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -522,7 +522,13 @@ CONFIG_V4L_PLATFORM_DRIVERS=y
 CONFIG_SOC_CAMERA=m
 CONFIG_SOC_CAMERA_PLATFORM=m
 CONFIG_VIDEO_RCAR_VIN=m
+CONFIG_VIDEO_SAMSUNG_EXYNOS4_IS=m
+CONFIG_VIDEO_S5P_FIMC=m
+CONFIG_VIDEO_S5P_MIPI_CSIS=m
+CONFIG_VIDEO_EXYNOS_FIMC_LITE=m
+CONFIG_VIDEO_EXYNOS4_FIMC_IS=m
 CONFIG_V4L_MEM2MEM_DRIVERS=y
+CONFIG_VIDEO_SAMSUNG_S5P_JPEG=m
 CONFIG_VIDEO_RENESAS_JPU=m
 CONFIG_VIDEO_RENESAS_VSP1=m
 # CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set
-- 
2.5.5

Re: [RESEND PATCH v3 1/2] ARM: exynos_defconfig: Enable Samsung media platform drivers as modules

[Javier Martinez Canillas]

Hello,

On 04/28/2016 09:40 AM, Javier Martinez Canillas wrote:
> There are a bunch of media platform drivers under drivers/media/platform/
> that are for Samsung SoCs but are not being built with exynos_defconfig.
> 
> This patch enables them as a module to improve build coverage for these
> drivers and also to allow people use them with proper hardware if modules
> are installed. The S5P MFC driver wasn't enabled since it fails to probe.
> 
> Only the boolean Kconfig symbols are enabled as built-in, since drivers
> are not critical and also to keep the kernel binary image size as small
> as possible.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> ---
> 
> Hello,
> 
> I'm resending the patches because Krzysztof pointed out that they didn't
> end in patchwork. Sorry for the noise.
> 
> I tested posting just to LKML (without people in cc) and the patches
> hit LKML this time as you can see in patchwork [0,1].
> 
> [0]: https://patchwork.kernel.org/patch/8970731/
> [1]: https://patchwork.kernel.org/patch/8970711/
> 
> So, I'm posting again with people on cc, hopefully it will work this time.
>

Sigh, it didn't made to LKML again after adding the people as cc...

I don't know what's wrong, I get no errors on my side and is the company
mail server so I don't have access to the logs to see why are bouncing.

As I mentioned, the previous attempts without people in cc made it to LKML:

https://lkml.org/lkml/2016/4/28/424
https://lkml.org/lkml/2016/4/28/422 

Krzysztof,

Is that enough for you to pick these? I'm so sorry for the inconvenience.

> Best regards,
> Javier
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Re: [RESEND PATCH v3 2/2] ARM: multi_v7_defconfig: Enable Samsung media platform drivers as modules

[Krzysztof Kozlowski]

On 04/28/2016 03:40 PM, Javier Martinez Canillas wrote:
> There are a bunch of media platform drivers under drivers/media/platform/
> for Samsung SoCs that are enabled in exynos_defconfig but no in multi_v7.
> 
> This patch enables them as a module to improve build coverage for these
> drivers and also to allow people use them with proper hardware if modules
> are installed.
> 
> Suggested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> ---
> 
> Changes in v3: None
> Changes in v2: None
> 
>  arch/arm/configs/multi_v7_defconfig | 6 ++++++
>  1 file changed, 6 insertions(+)

Looks good to me, I'll take it for next release. As for the record:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Re: [RESEND PATCH v3 1/2] ARM: exynos_defconfig: Enable Samsung media platform drivers as modules

[Krzysztof Kozlowski]

On 04/28/2016 03:40 PM, Javier Martinez Canillas wrote:
> There are a bunch of media platform drivers under drivers/media/platform/
> that are for Samsung SoCs but are not being built with exynos_defconfig.
> 
> This patch enables them as a module to improve build coverage for these
> drivers and also to allow people use them with proper hardware if modules
> are installed. The S5P MFC driver wasn't enabled since it fails to probe.
> 
> Only the boolean Kconfig symbols are enabled as built-in, since drivers
> are not critical and also to keep the kernel binary image size as small
> as possible.
> 
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
> ---
> 
> Hello,
> 
> I'm resending the patches because Krzysztof pointed out that they didn't
> end in patchwork. Sorry for the noise.
> 
> I tested posting just to LKML (without people in cc) and the patches
> hit LKML this time as you can see in patchwork [0,1].
> 
> [0]: https://patchwork.kernel.org/patch/8970731/
> [1]: https://patchwork.kernel.org/patch/8970711/
> 
> So, I'm posting again with people on cc, hopefully it will work this time.
> 
> Best regards,
> Javier
> 
> Changes in v3:
> - Added Krzysztof Kozlowski's reviewed by tag.
> 
> Changes in v2:
> - Remove S5P G2D and GSC symbols since overlaps with Exynos DRM functionality.
>   Suggested by Tobias Jakobi
> 

Thanks, applied both.

Krzysztof