From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753852AbcEBN72 (ORCPT ); Mon, 2 May 2016 09:59:28 -0400 Received: from mail-bl2on0057.outbound.protection.outlook.com ([65.55.169.57]:50592 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750844AbcEBN7S (ORCPT ); Mon, 2 May 2016 09:59:18 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=amd.com; Subject: Re: [PATCH] crypto: constify ccp_actions structure To: Julia Lawall , References: <1462103575-21705-1-git-send-email-Julia.Lawall@lip6.fr> CC: Tom Lendacky , , Gary Hook , Herbert Xu , "David S. Miller" , From: Gary R Hook Message-ID: <57275D0A.3030208@amd.com> Date: Mon, 2 May 2016 08:58:34 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1462103575-21705-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY1PR14CA0016.namprd14.prod.outlook.com (10.163.13.154) To BY2PR12MB0338.namprd12.prod.outlook.com (10.162.84.13) X-MS-Office365-Filtering-Correlation-Id: 25591d6f-4d89-46dc-87d0-08d37291f25b X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0338;2:Njfa5hvNpUxkPyRnx+5nrGu3K3r56rYOXarG5csSbpUSuUkqaObjC2wKUZQz+abkdI5kBV4aGPWst3vpJI8aNzw9XtQTGDOSVDNP9w7OdmMsTKfe0Jbpkps0P1yEcL/Dc7hLx3uHVixvx01xO0EAAfsfKSeWAB5XsZRiwRi8ppvF6hd2ti2HnEBHJ8FAZRgk;3:GXpzOohuM+lVoIf4g2ZnHNebaGrCrUbMI5YJPOU8OwbIcaktjXnCzraF3CBN4NySE6I6booO+sIE6esnQQo854Ha1QvrmuNo2OcyF77YKLFvfgWbBhmR686KC34BRZuV;25:QchIml3ouHXwEbNlEbc5E+mv259+vd9okJG6BNvsCiKaZrM1dLMQpGWhnP8EhjTHxzAXgYteKlls1aQEE9FL0QVplSpuv1zbWtMjubWWQrhZ22qg4sCFR5b1uTE0lbjupBcniR6V2r0LNVqvC3Cbv2WAqufZ11/oU4Y+c/d7jF+AgFjTTWhc3hKvqahX2ntd+RnW18OhaSGf5qGPfCtvsBzFojkxRaUpRrKfrMmfXrop9IAv9XHF3VLunyFOKl1QNrch5d1CIAMBlwIiOR8zIt6VrP6rB5RIvV0H0ID1O0imCHqVg6R/bp2acpiprFYS1KgE0xvS+rGK3lE+Lo+8/A== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0338; X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0338;20:124b7wcJLtlHFoVjZEOqIta0GLV4EQzvFmmAXF0xPBKD6Zrq7F6W3aenpFyBvK4B4tsedrhKTSOpB5PakGD5/DX6WLhXQv8Juh9IQQ0lahHF2wyJoFW60Pgk4pf/2KRZu8shEvK6JTOCGd3N9C7HwOElUIpwKORhzIuEQ/IfONjvil+6yGmVbZlpQVD7U9yl3CIHFXiub5shDPjPW/Xq/Zckr9s8JxCNwb/wzjqkNl8dd93rxhdYDoATt79Pd8/7vIZgSk+wM0ZjHB/sRdUodDrCF8rCPFyiuHlpBRgI4zGxtEE1ryK4bKoQLzVXpLX/vFcximdm7Zv+Znfy7DU000Zs8lMYWR1GUrjZ0GGaACDI/UlGV51QmsURTcVZDm8WezFYAVkqtedA6TfM47XtUqNXKdfhPSsVvy4nO4H1+Rtw2dWoCBbM1sHGn0LgZR4+m0KJDlO5+B010+BBZdO3kl+NweAkBjgS6Zk40xy14kmE6xmpPxpPYB8ylqyrmLqs;4:F6FBUBIoQnt5KObZHgntSTKDKxebE5wFJyUCN0zbJsxiUwBeQWre2pfuQyqbYqKSs9PlSttWXxYXs8DSmkfTRdwmytlE6sHy4igA6sHoiziX7ssXd3lo9SOBanz+2aRaMbSYy76l4zJ4maCoa/QTOUaGrR8ud5EDhPL6G/tX6qRsF6gMApomULM0Plk0qOk6FbziP2KbAklvI+U5RnO1MgGLBTeSX/6XIZ9UVnzy530GHz/CxffT616lL+aWl2MZdxNZwn2pfGwzRxgK/UWvqGv6fMHwio05FNPDh+EUNE8HEIU3QPAKA/Nkj/a2mWUx0rpdYx9CwutdesupkyjJvn2Kquadgpe5co68NQgfqSR3rJsJxwSNnZ0X9noFzQCaEtBT3fVvYI82fkFV/2nnnFCUKvmhDqPaMjK84QCutp0= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(9101521094)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:BY2PR12MB0338;BCL:0;PCL:0;RULEID:;SRVR:BY2PR12MB0338; X-Forefront-PRVS: 0930AAFAD9 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6049001)(6009001)(24454002)(377454003)(6116002)(19580395003)(3846002)(586003)(189998001)(80316001)(92566002)(33656002)(5008740100001)(50986999)(5004730100002)(81166005)(42186005)(83506001)(19580405001)(66066001)(1096002)(36756003)(4326007)(23746002)(99136001)(76176999)(87266999)(5001770100001)(64126003)(2950100001)(77096005)(47776003)(230700001)(2906002)(50466002)(54356999)(65956001)(65816999)(4001350100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2PR12MB0338;H:[10.236.19.42];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2PR12MB0338;23:DMerIurXs8xvbbOGPG5oCIlkmWbdDJliYIIcK?= =?Windows-1252?Q?7DXu1GSnVt7/wjFHiZE/Xsib3EVCSCstcq0oVQu0Pf512oapoFfYOz4y?= =?Windows-1252?Q?ZpavYIuexoHEkMvgF6lbpPGFMLKQ7zdeqMTkDtgAvxMlLrQ3Mk6cbDiV?= =?Windows-1252?Q?F9/My8q5u9LiUeT4pj61T40LWnkrVLsKr9tCWQ75focwijh/cfPrS00j?= =?Windows-1252?Q?R54ks571Fc77bl/z6sWVUUnTvO1PLDMp6F+cdJsZrVAY59tyQLrfo3yW?= =?Windows-1252?Q?AtzsS+ueO06fqAmNDt5wDiXNzLVWlwchP1+5tokVHR+iJe3+pV6b8J7y?= =?Windows-1252?Q?AjJ1uduDldLKZRGqLA29aLfAjirhcLDA385P4OIcg0RpRAkEdRFxPisP?= =?Windows-1252?Q?S3Q6HSAg1LcbxTKBG1GTEkaa/LV+zcLrK5GoEpWeEat6fBHIlCGJzA8G?= =?Windows-1252?Q?+vtOXTv1k4XuWM3fx6iUnEpAr9o723LrIJbzyRV0aa3NoAmR75F+isKQ?= =?Windows-1252?Q?rfKRURJefkzAUsfWulsECWf+zdsJ7/4ccKmYY4XRmT9PQU24RxzWjPzO?= =?Windows-1252?Q?qEO37xyvSMQNqBVp0xotu574vafpRKXJVSP5lVNyLhdwJJV9ISk3jW5O?= =?Windows-1252?Q?hgalyxxPY/EF1Xo+XZGq7f0mB8R5zMwVdDJMo7n9e0rmBFsfMaW+4N6c?= =?Windows-1252?Q?v4yvcPr0PWkxDBKoGS0E93DKwVkndV2YYsvWG79usjIqHkZ3ys08Ez4t?= =?Windows-1252?Q?7jJx3mvgamxSypSJZ3RgE6CXKEzTDRKeZcF6zrlnkk3LV/teLcY3Fndd?= =?Windows-1252?Q?K7GKHlH3W3n5ODug9oRixFhiQgzfmVueDmh9c8uOcc9MoNgwMQ7O1p5i?= =?Windows-1252?Q?W9VNqimXDNf8Qo67vx7SiwrZ1Xez1LpCLY5gLNu1vGdea2l3SYSkcLid?= =?Windows-1252?Q?TDAF/hmXAOkdLTn1QpqLAnlJgOTgbRgFO0w9A31MJK06M3OqmxX0r7J4?= =?Windows-1252?Q?lIDb3EatvNSyjDPIKGsVNZGIeD47TeoqgNhylCgZHBjyjY56G9QVtHHs?= =?Windows-1252?Q?MzTI+XFGsXcq1OwwoZesX2Jaii/67IJRHz//iHmELVEoFfvb2nF4L4XG?= =?Windows-1252?Q?Ut6FxiZA+hENOGifnzDpN38m4lEB7fiFFxumtHk68r3?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR12MB0338;5:tw6zmGNxu8CFLXvUFhlA/PR/u9AHtwzBEzZ0Q3dFPWKOjK8L0CuO2F3L1VfLnCT48cKT+xTR6/uqZoggVMxWClxjP6dGzyg4sa5F8iFKiD5R81qSF4rrzMRu+Jn5OSYXlIDdmcy9tlHMO0C12JP+sA==;24:v8B9l1Fz0XYEZ1Qr+CIVnIra9sAWU2b1yWQqbIuAPkR98slNjd+qaw7CPK8TAMr7e+61g2EoMLA5p8XsyCNpQcNMzT1KPCETAj6UEg58KhU=;7:dkAZQciTRImX2YP0CVVixYwjrT6emmITqkrkRye1MxhfXiTO7YQnwqd1T1Q74nagclqwuhpZXVJp9Ypv2jhmt4QhrE5ZF0u6dqQWLI8BUnByyKSs7GdM886v6KmzbeBnOq4SJvn8CwzaJ+rfHBDCbtt7sszfSK6+uRr0Jtmtapg=;20:XgYeBNQnJHNxfmj99V35bsyy5JLOBN1M8PuAzwxbUnI1FXn2FshMoCgu28ZZo+4BccX/fboyB2tiPqIK9lFsxg6eVUWnsK1GdmKS/56zC0mtMxLXE3/889Jnw8HmlKgw1ZgAdpuMkSptnepGI1BhM9cpxxXDC+tpX3GTnH/tpY6ipeIGKjAY9pQWxIgTNTn78I66IyC1HUugbQS4/9kP4x0aQnUjzzp1MYXjo5RYKkb07KtMkpojdOk1G3MaOfa+ X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2016 13:59:14.5499 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR12MB0338 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/01/2016 06:52 AM, Julia Lawall wrote: > The ccp_actions structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Acked-by: Gary Hook > --- > drivers/crypto/ccp/ccp-dev-v3.c | 2 +- > drivers/crypto/ccp/ccp-dev.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/ccp/ccp-dev-v3.c b/drivers/crypto/ccp/ccp-dev-v3.c > index 597fc50..d7a7103 100644 > --- a/drivers/crypto/ccp/ccp-dev-v3.c > +++ b/drivers/crypto/ccp/ccp-dev-v3.c > @@ -526,7 +526,7 @@ static irqreturn_t ccp_irq_handler(int irq, void *data) > return IRQ_HANDLED; > } > > -static struct ccp_actions ccp3_actions = { > +static const struct ccp_actions ccp3_actions = { > .perform_aes = ccp_perform_aes, > .perform_xts_aes = ccp_perform_xts_aes, > .perform_sha = ccp_perform_sha, > diff --git a/drivers/crypto/ccp/ccp-dev.h b/drivers/crypto/ccp/ccp-dev.h > index 5d986c9..bd41ffce 100644 > --- a/drivers/crypto/ccp/ccp-dev.h > +++ b/drivers/crypto/ccp/ccp-dev.h > @@ -162,7 +162,7 @@ struct ccp_actions { > /* Structure to hold CCP version-specific values */ > struct ccp_vdata { > unsigned int version; > - struct ccp_actions *perform; > + const struct ccp_actions *perform; > }; > > extern struct ccp_vdata ccpv3; >