From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754009AbcEBPIK (ORCPT ); Mon, 2 May 2016 11:08:10 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:1690 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751623AbcEBPIG (ORCPT ); Mon, 2 May 2016 11:08:06 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Mon, 02 May 2016 08:07:08 -0700 Subject: Re: [PATCH 1/1] pinctrl: tegra: avoid parked_reg and parked_bank To: Laxman Dewangan , , , References: <1462199330-1536-1-git-send-email-ldewangan@nvidia.com> CC: , , , From: Rhyland Klein Message-ID: <57276D4E.2020204@nvidia.com> Date: Mon, 2 May 2016 11:07:58 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1462199330-1536-1-git-send-email-ldewangan@nvidia.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/2/2016 10:28 AM, Laxman Dewangan wrote: > NVIDIA's Tegra210 support the park bit to make pinmux configuration > enable/disable. If parked bit is 1 then configuration does not apply > and if it is 0 then pinmux configuration applies. This is to support > to avoid any glitch in pinmux configurations. > > The parked bit is part of mux register and mux bank and hence it is > not required to have member for the parked_reg and parked bank very > similar to other bit field of the same register. > > Remove the need of the parked register and parked bank and get whether > parked function supported or not by parked_bit. > > This is to make the parked bit handling same as other fields of mux > registers. > > Signed-off-by: Laxman Dewangan > --- > drivers/pinctrl/tegra/pinctrl-tegra.c | 8 ++++---- > drivers/pinctrl/tegra/pinctrl-tegra.h | 6 +----- > drivers/pinctrl/tegra/pinctrl-tegra114.c | 4 ++-- > drivers/pinctrl/tegra/pinctrl-tegra124.c | 4 ++-- > drivers/pinctrl/tegra/pinctrl-tegra20.c | 4 ++-- > drivers/pinctrl/tegra/pinctrl-tegra210.c | 4 +--- > drivers/pinctrl/tegra/pinctrl-tegra30.c | 4 ++-- > 7 files changed, 14 insertions(+), 20 deletions(-) > These drivers are generated (with the exception of Tegra20) by the tegra-pinmux-scripts hosted at : https://github.com/NVIDIA/tegra-pinmux-scripts.git. Did you generate a patch there so that the changes to pinctrl-tegra[114|124|210|30].c are consistent there? If not you probably should. -rhyland -- nvpublic