From: Lu Baolu <baolu.lu@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: felipe.balbi@linux.intel.com,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface
Date: Tue, 3 May 2016 09:43:58 +0800 [thread overview]
Message-ID: <5728025E.9040902@linux.intel.com> (raw)
In-Reply-To: <20160502110001.GF6292@sirena.org.uk>
Hi,
On 05/02/2016 07:00 PM, Mark Brown wrote:
> On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote:
>
>> + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS);
>> + if (IS_ERR(gpiod))
>> + return PTR_ERR(gpiod);
> This is clearly an inappropriate name for the signal in generic code,
> it's specific to your use case.
I will change the gpio name to "gpio". Is that okay?
Best regards,
Lu Baolu
next prev parent reply other threads:[~2016-05-03 1:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 6:26 [PATCH v7 0/7] usb: add support for Intel dual role port mux Lu Baolu
2016-04-29 6:26 ` [PATCH v7 1/7] regulator: fixed: add support for ACPI interface Lu Baolu
2016-05-02 11:00 ` Mark Brown
2016-05-03 1:43 ` Lu Baolu [this message]
2016-05-03 11:49 ` Mark Brown
2016-05-04 0:25 ` Lu Baolu
2016-04-29 6:26 ` [PATCH v7 2/7] usb: mux: add generic code for dual role port mux Lu Baolu
2016-04-29 6:26 ` [PATCH v7 3/7] usb: mux: add driver for Intel gpio controlled " Lu Baolu
2016-04-29 6:26 ` [PATCH v7 4/7] usb: mux: add driver for Intel drcfg " Lu Baolu
2016-04-29 6:26 ` [PATCH v7 5/7] mfd: intel_vuport: Add Intel virtual USB port MFD Driver Lu Baolu
2016-04-29 6:26 ` [PATCH v7 6/7] usb: pci-quirks: add Intel USB drcfg mux device Lu Baolu
2016-04-29 6:26 ` [PATCH v7 7/7] MAINTAINERS: add maintainer entry for Intel USB dual role mux drivers Lu Baolu
2016-05-02 3:13 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5728025E.9040902@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=broonie@kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox