From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933067AbcECBoH (ORCPT <rfc822;w@1wt.eu>);
	Mon, 2 May 2016 21:44:07 -0400
Received: from mga09.intel.com ([134.134.136.24]:8845 "EHLO mga09.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932377AbcECBoD (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 2 May 2016 21:44:03 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,570,1455004800"; 
   d="scan'208";a="797352855"
Subject: Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface
To: Mark Brown <broonie@kernel.org>
References: <1461911198-2895-1-git-send-email-baolu.lu@linux.intel.com>
 <1461911198-2895-2-git-send-email-baolu.lu@linux.intel.com>
 <20160502110001.GF6292@sirena.org.uk>
Cc: felipe.balbi@linux.intel.com, Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Lee Jones <lee.jones@linaro.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Liam Girdwood <lgirdwood@gmail.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
From: Lu Baolu <baolu.lu@linux.intel.com>
Message-ID: <5728025E.9040902@linux.intel.com>
Date: Tue, 3 May 2016 09:43:58 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160502110001.GF6292@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 05/02/2016 07:00 PM, Mark Brown wrote:
> On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote:
>
>> +	gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS);
>> +	if (IS_ERR(gpiod))
>> +		return PTR_ERR(gpiod);
> This is clearly an inappropriate name for the signal in generic code,
> it's specific to your use case.

I will change the gpio name to "gpio". Is that okay?

Best regards,
Lu Baolu