From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755350AbcECGdX (ORCPT ); Tue, 3 May 2016 02:33:23 -0400 Received: from regular2.263xmail.com ([211.157.152.4]:49184 "EHLO regular2.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750779AbcECGdV (ORCPT ); Tue, 3 May 2016 02:33:21 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 104.37.5.204 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: <7226eb6a7a3fa52b9ac13f40887452bc> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 2/4] thermal: of: implement .set_trips for device tree thermal zones To: Eduardo Valentin References: <1461553367-24744-1-git-send-email-wxt@rock-chips.com> <1461553367-24744-3-git-send-email-wxt@rock-chips.com> <20160427215209.GC6438@localhost.localdomain> Cc: Heiko Stuebner , dianders@chromium.org, briannorris@google.com, smbarber@google.com, linux-rockchip@lists.infradead.org, dmitry.torokhov@gmail.com, huangtao@rock-chips.com, eddie.cai@rock-chips.com, Sascha Hauer , Zhang Rui , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org From: Caesar Wang Message-ID: <5728460E.4000009@rock-chips.com> Date: Tue, 3 May 2016 14:32:46 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <20160427215209.GC6438@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2016年04月28日 05:52, Eduardo Valentin 写道: > On Mon, Apr 25, 2016 at 11:02:45AM +0800, Caesar Wang wrote: >> From: Sascha Hauer >> >> Signed-off-by: Sascha Hauer >> Signed-off-by: Caesar Wang >> Cc: Zhang Rui >> Cc: Eduardo Valentin >> Cc: linux-pm@vger.kernel.org >> --- >> >> drivers/thermal/of-thermal.c | 12 ++++++++++++ >> include/linux/thermal.h | 4 ++++ >> 2 files changed, 16 insertions(+) >> >> diff --git a/drivers/thermal/of-thermal.c b/drivers/thermal/of-thermal.c >> index b8e509c..8722e63 100644 >> --- a/drivers/thermal/of-thermal.c >> +++ b/drivers/thermal/of-thermal.c >> @@ -101,6 +101,17 @@ static int of_thermal_get_temp(struct thermal_zone_device *tz, >> return data->ops->get_temp(data->sensor_data, temp); >> } >> >> +static int of_thermal_set_trips(struct thermal_zone_device *tz, >> + int low, int high) >> +{ >> + struct __thermal_zone *data = tz->devdata; >> + >> + if (!data->ops || !data->ops->set_trips) >> + return -EINVAL; >> + >> + return data->ops->set_trips(data->sensor_data, low, high); >> +} >> + >> /** >> * of_thermal_get_ntrips - function to export number of available trip >> * points. >> @@ -427,6 +438,7 @@ thermal_zone_of_add_sensor(struct device_node *zone, >> >> tzd->ops->get_temp = of_thermal_get_temp; >> tzd->ops->get_trend = of_thermal_get_trend; >> + tzd->ops->set_trips = of_thermal_set_trips; >> tzd->ops->set_emul_temp = of_thermal_set_emul_temp; >> mutex_unlock(&tzd->lock); >> >> diff --git a/include/linux/thermal.h b/include/linux/thermal.h >> index e258359..cb64866 100644 >> --- a/include/linux/thermal.h >> +++ b/include/linux/thermal.h >> @@ -336,12 +336,16 @@ struct thermal_genl_event { >> * >> * Optional: >> * @get_trend: a pointer to a function that reads the sensor temperature trend. >> + * @@set_trips: a pointer to a function that sets a temperature window. When >> + * this window is left the driver must inform the thermal core via >> + * thermal_zone_device_update. > Ok. We start to see some documentation and expectation being stated > here. Nice. Please respin the comment on thermal core too, so drivers > that dont use OF will also be aware of this feature and how to use them. Okay, done > >> * @set_emul_temp: a pointer to a function that sets sensor emulated >> * temperature. >> */ >> struct thermal_zone_of_device_ops { >> int (*get_temp)(void *, int *); >> int (*get_trend)(void *, long *); >> + int (*set_trips)(void *, int, int); >> int (*set_emul_temp)(void *, int); >> int (*set_trip_temp)(void *, int, int); >> }; >> -- >> 1.9.1 >> > > -- caesar wang | software engineer | wxt@rock-chip.com