From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932810AbcECLnK (ORCPT ); Tue, 3 May 2016 07:43:10 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:14963 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932269AbcECLnH (ORCPT ); Tue, 3 May 2016 07:43:07 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 03 May 2016 04:42:30 -0700 Subject: Re: [PATCH 2/6] soc/tegra: pmc: Correct type of variable for tegra_pmc_readl() To: Laxman Dewangan , , , , , , References: <1462191434-28933-1-git-send-email-ldewangan@nvidia.com> <1462191434-28933-3-git-send-email-ldewangan@nvidia.com> CC: , , , X-Nvconfidentiality: public From: Jon Hunter Message-ID: <57288EC3.3090001@nvidia.com> Date: Tue, 3 May 2016 12:42:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1462191434-28933-3-git-send-email-ldewangan@nvidia.com> X-Originating-IP: [10.21.132.133] X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/05/16 13:17, Laxman Dewangan wrote: > The function tegra_pmc_readl() returns the u32 type data and hence > change the data type of variable where this data is stored to u32 > type. > > Signed-off-by: Laxman Dewangan > > --- > Changes from V1: > -This is new in series as per discussion on V1 series to use u32 for > tegra_pmc_readl. > --- > drivers/soc/tegra/pmc.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c > index 2c3f1f9..fc4f7b2 100644 > --- a/drivers/soc/tegra/pmc.c > +++ b/drivers/soc/tegra/pmc.c > @@ -878,7 +878,7 @@ static int tegra_io_rail_prepare(unsigned int id, unsigned long *request, > static int tegra_io_rail_poll(unsigned long offset, unsigned long mask, > unsigned long val, unsigned long timeout) > { > - unsigned long value; > + u32 value; You also need to make mask and val a u32. Jon