From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933415AbcECNBI (ORCPT ); Tue, 3 May 2016 09:01:08 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:19735 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932762AbcECNBF (ORCPT ); Tue, 3 May 2016 09:01:05 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Tue, 03 May 2016 06:00:03 -0700 Message-ID: <57289E35.8040400@nvidia.com> Date: Tue, 3 May 2016 18:18:53 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Jon Hunter , , , , , , CC: , , , Subject: Re: [PATCH 3/6] soc/tegra: pmc: Add support for IO pads power state and voltage References: <1462191434-28933-1-git-send-email-ldewangan@nvidia.com> <1462191434-28933-4-git-send-email-ldewangan@nvidia.com> <57289AC0.4090604@nvidia.com> <57289A2B.7040501@nvidia.com> <57289FB5.5040705@nvidia.com> In-Reply-To: <57289FB5.5040705@nvidia.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: BGMAIL102.nvidia.com (10.25.59.11) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 03 May 2016 06:25 PM, Jon Hunter wrote: > >> >> Currently SOR driver is using the tegra_io_rail_power_off/on() APIs. >> Once the proper interface available then I will move sor driver to use >> new method and then we can full get rid of older APIs and macros. >> >> Till that, we need to have this. > I prefer it is done before this series. In other words, if we need a > proper enum for the rail/pad IDs then add one and convert any existing > drivers over to use any new APIs first. But the converting to new API can be done after this patch only. I need to implement new APIs and then move driver to use new APIs and then remove older one. Otherwise, I need to have single patch for the new API + converting existing user to use new APIs. If this is allowed in subsystem level then this is best method. We already did for max77686 RTC + mfd change together. So will it be fine to make such changes?