From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933435AbcECNGq (ORCPT ); Tue, 3 May 2016 09:06:46 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:4104 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932762AbcECNGo (ORCPT ); Tue, 3 May 2016 09:06:44 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Tue, 03 May 2016 06:06:07 -0700 Message-ID: <57289F88.6040203@nvidia.com> Date: Tue, 3 May 2016 18:24:32 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Jon Hunter , , , , , , CC: , , , Subject: Re: [PATCH 5/6] pinctrl: tegra: Add DT binding for io pads control References: <1462191434-28933-1-git-send-email-ldewangan@nvidia.com> <1462191434-28933-6-git-send-email-ldewangan@nvidia.com> <57289D3D.40301@nvidia.com> In-Reply-To: <57289D3D.40301@nvidia.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: BGMAIL102.nvidia.com (10.25.59.11) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 03 May 2016 06:14 PM, Jon Hunter wrote: > On 02/05/16 13:17, Laxman Dewangan wrote: >> + >> +The voltage supported on the pads are 1.8V and 3.3V. The enums are defined as: >> + For 1.8V, use TEGRA_IO_PAD_POWER_SOURCE_1800000UV >> + For 3.3V, use TEGRA_IO_PAD_POWER_SOURCE_3300000UV > Are these still necessary now that the driver is using uV? Can't we just > use integer values for 1800000 and 3300000 in the DTS directly? > The config param and value are packed in u32 with 16bit each So we can not make uV in 16bit until we do conversion of uV->mV. Hence suggestion came from Stephen that we can have enum for Nvidia specific and what actually it supports by HW. HW does not support any other voltage. >> +Required subnode-properties: >> +========================== >> +- pins : An array of strings. Each string contains the name of an IO pads. Valid >> + values for these names are listed below. > Please see my previous comments. This is taken from other dt binding docs for description. We can have array of string. As all value of pins are not supporting all property and hence I explicitly wrote under properties. > >> +Optional subnode-properties: >> +========================== >> +-nvidia,power-source-voltage: Integer. The voltage level of IO pads. The > I think I prefer nvidia,io-voltage or something. You can describe what > this means in this doc. In fact, the current description here does not > explicitly state that this voltage, is the voltage the pad is configured > to operate at versus the voltage of the IO rail. Linus suggested this dt property name to make more readable and generic and meaningful with other property :power-source.