From: Jon Hunter <jonathanh@nvidia.com>
To: Laxman Dewangan <ldewangan@nvidia.com>, <swarren@wwwdotorg.org>,
<linus.walleij@linaro.org>, <gnurou@gmail.com>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<thierry.reding@gmail.com>
Cc: <linux-tegra@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 3/6] soc/tegra: pmc: Add support for IO pads power state and voltage
Date: Tue, 3 May 2016 14:12:01 +0100 [thread overview]
Message-ID: <5728A3A1.2030304@nvidia.com> (raw)
In-Reply-To: <57289E35.8040400@nvidia.com>
On 03/05/16 13:48, Laxman Dewangan wrote:
>
> On Tuesday 03 May 2016 06:25 PM, Jon Hunter wrote:
>>
>>>
>>> Currently SOR driver is using the tegra_io_rail_power_off/on() APIs.
>>> Once the proper interface available then I will move sor driver to use
>>> new method and then we can full get rid of older APIs and macros.
>>>
>>> Till that, we need to have this.
>> I prefer it is done before this series. In other words, if we need a
>> proper enum for the rail/pad IDs then add one and convert any existing
>> drivers over to use any new APIs first.
>
> But the converting to new API can be done after this patch only.
Yes but before you add the pinctrl driver. May be you should separate
the two.
My point is that any follow-up series to this, would have to touch the
pmc and the sor driver. So why not make the changes for the pmc and sor
now, and once in place then add the pinctrl driver?
Jon
next prev parent reply other threads:[~2016-05-03 13:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 12:17 [PATCH 0/6] soc/tegra: Add support for IO pads control via pinctrl interface Laxman Dewangan
2016-05-02 12:17 ` [PATCH 1/6] soc/tegra: pmc: Use BIT macro for register field definition Laxman Dewangan
2016-05-02 12:17 ` [PATCH 2/6] soc/tegra: pmc: Correct type of variable for tegra_pmc_readl() Laxman Dewangan
2016-05-03 11:42 ` Jon Hunter
2016-05-02 12:17 ` [PATCH 3/6] soc/tegra: pmc: Add support for IO pads power state and voltage Laxman Dewangan
2016-05-03 12:34 ` Jon Hunter
2016-05-03 12:31 ` Laxman Dewangan
2016-05-03 12:55 ` Jon Hunter
2016-05-03 12:48 ` Laxman Dewangan
2016-05-03 13:12 ` Jon Hunter [this message]
2016-05-03 13:07 ` Laxman Dewangan
2016-05-02 12:17 ` [PATCH 4/6] soc/tegra: pmc: Register PMC child devices as platform device Laxman Dewangan
2016-05-03 12:36 ` Jon Hunter
2016-05-03 15:26 ` Jon Hunter
2016-05-02 12:17 ` [PATCH 5/6] pinctrl: tegra: Add DT binding for io pads control Laxman Dewangan
2016-05-03 12:44 ` Jon Hunter
2016-05-03 12:54 ` Laxman Dewangan
2016-05-03 13:33 ` Jon Hunter
2016-05-02 12:17 ` [PATCH 6/6] pinctrl: tegra: Add driver to configure voltage and power state of io pads Laxman Dewangan
2016-05-11 9:19 ` Linus Walleij
2016-05-11 16:07 ` Stephen Warren
2016-05-12 10:30 ` Jon Hunter
2016-05-12 19:02 ` Javier Martinez Canillas
2016-05-12 19:48 ` Jon Hunter
2016-05-03 11:38 ` [PATCH 0/6] soc/tegra: Add support for IO pads control via pinctrl interface Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5728A3A1.2030304@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox