From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933130AbcECO0J (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 May 2016 10:26:09 -0400
Received: from mail-wm0-f52.google.com ([74.125.82.52]:35159 "EHLO
	mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932943AbcECO0H (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 May 2016 10:26:07 -0400
Subject: Re: [report] invalid error code in do_register_con_driver() console
To: Dan Carpenter <dan.carpenter@oracle.com>
References: <20160225213409.GD18267@mwanda>
Cc: linux-kernel@vger.kernel.org
From: Jiri Slaby <jslaby@suse.cz>
Message-ID: <5728B4FB.8090208@suse.cz>
Date: Tue, 3 May 2016 16:26:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <20160225213409.GD18267@mwanda>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 02/25/2016, 10:34 PM, Dan Carpenter wrote:
> Hi Jiri,
> 
> I'm getting the following static checker warning:
> 
> 	drivers/tty/vt/vt.c:3588 do_register_con_driver()
> 	warn: missing error code here? 'csw->con_startup()' failed. 'retval' = '0'
> 
> drivers/tty/vt/vt.c
>   3582          if (retval)
>   3583                  goto err;
>   3584  
>   3585          desc = csw->con_startup();
>   3586  
>   3587          if (!desc)
>   3588                  goto err;
>   3589  
>   3590          retval = -EINVAL;
>   3591  
> 
> Probably, we could more the "retval = -EINVAL;" before the goto?  I
> don't think it's intentional?

Yes, you are right. I've prepared a fix to send out.

thanks,
-- 
js
suse labs