From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933369AbcECPK2 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 3 May 2016 11:10:28 -0400
Received: from mga02.intel.com ([134.134.136.20]:47537 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755316AbcECPK1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 3 May 2016 11:10:27 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.24,572,1455004800"; 
   d="scan'208";a="945249562"
Subject: Re: [PATCH v2 2/4] x86, boot: PUD VA support for physical mapping
 (x86_64)
To: Baoquan He <bhe@redhat.com>
References: <1462225276-106993-1-git-send-email-thgarnie@google.com>
 <1462225276-106993-3-git-send-email-thgarnie@google.com>
 <5727CD69.7040901@linux.intel.com> <20160503100530.GC3287@x1.redhat.com>
Cc: Thomas Garnier <thgarnie@google.com>, "H . Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        Borislav Petkov <bp@suse.de>, Andy Lutomirski <luto@kernel.org>,
        Dmitry Vyukov <dvyukov@google.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Kees Cook <keescook@chromium.org>, Stephen Smalley <sds@tycho.nsa.gov>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Matt Fleming <matt@codeblueprint.co.uk>,
        Toshi Kani <toshi.kani@hpe.com>,
        Alexander Kuleshov <kuleshovmail@gmail.com>,
        Alexander Popov <alpopov@ptsecurity.com>,
        Joerg Roedel <jroedel@suse.de>, Dave Young <dyoung@redhat.com>,
        Mark Salter <msalter@redhat.com>,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        gthelen@google.com, kernel-hardening@lists.openwall.com
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <5728BF03.1050303@linux.intel.com>
Date: Tue, 3 May 2016 08:08:51 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <20160503100530.GC3287@x1.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/03/2016 03:05 AM, Baoquan He wrote:
> I have a tiny concern about phys_pmd_init(), both phys_pud_init and
> phys_pte_init name 2nd parameter as 'addr', phys_pmd_init use 'address'.
> If this can be changed to make them look consistent completist would
> have a good sleep from now on.

Yes, consistency would be nice.  Even better would be to call them all
'phys_addr'.