From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933756AbcECPrb (ORCPT ); Tue, 3 May 2016 11:47:31 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:64014 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933320AbcECPr3 (ORCPT ); Tue, 3 May 2016 11:47:29 -0400 Subject: Re: [PATCH 09/18] ASoC: sti: Update DT example to match the driver code To: Peter Griffin , Mark Brown References: <1461236675-10176-1-git-send-email-peter.griffin@linaro.org> <1461236675-10176-10-git-send-email-peter.griffin@linaro.org> <20160421155753.GS3217@sirena.org.uk> <20160426110229.GA5374@griffinp-ThinkPad-X1-Carbon-2nd> CC: , , , , , , , , , , From: Arnaud Pouliquen X-Enigmail-Draft-Status: N1110 Message-ID: <5728C7B8.5050903@st.com> Date: Tue, 3 May 2016 17:46:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <20160426110229.GA5374@griffinp-ThinkPad-X1-Carbon-2nd> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.201.23.162] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-05-03_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/26/2016 01:02 PM, Peter Griffin wrote: > Hi Mark, > > On Thu, 21 Apr 2016, Mark Brown wrote: > >> On Thu, Apr 21, 2016 at 12:04:26PM +0100, Peter Griffin wrote: >>> uniperiph-id, version and mode are ST specific bindings and >>> need the 'st,' prefix. Update the examples, as otherwise copying >>> them yields a runtime error parsing the DT node. >> >> I'm not sure what connection this or the other ASoC documentation update >> have to the rest of the series? > > The ASoC DT bindings are missing upstream as the ASoC driver depends on the > fdma driver. So this series adds the fdma driver, fdma dt bindings, > and also the missing ASoC dt bindings. > > Whilst doing this and getting it working I noticed a few discrepencies > in the ASoC dt binding documentation versus the driver so also fixed that. > > Once this whole series is applied the end result is working > audio upstream for STi platforms (as ASoC is the only upstream driver > using fdma currently). Hi Peter, I also noticed the error in bindings, i'm planning to correct it with DTS upstream for STI ASoC after FDMA has been accepted. So if you estimate that it is simplier for FDMA upstream, you can drop ASoC patches in you next version. Regards, Arnaud