public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	Andy Lutomirski <luto@kernel.org>, Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] [RFC] x86: work around MPX Erratum
Date: Tue, 3 May 2016 14:04:40 -0700	[thread overview]
Message-ID: <57291268.3060006@intel.com> (raw)
In-Reply-To: <20160503064354.GA11112@gmail.com>

On 05/02/2016 11:43 PM, Ingo Molnar wrote:
>> > +static int is_mpx_affected_microarch(struct cpuinfo_x86 *c)
>> > +{
>> > +	/* Only family 6 is affected */
>> > +	if (c->x86 != 0x6)
>> > +		return 0;
>> > +
>> > +	/* We know these Atom models are unaffected, for sure */
>> > +	switch (c->x86_model) {
>> > +	case 0x5F: /* "Future Intel Atom ... Goldmont */
>> > +	case 0x5C: /* "Future Intel Atom ... Goldmont */
>> > +	     return 0;
>> > +	}
>> > +	/*
>> > +	 * We will get here on future unknown processors and all
>> > +	 * Core/Xeons.  They might be unaffected Atoms or
>> > +	 * affected Core/Xeons. Be conservative and assume
>> > +	 * processor is affected.
>> > +	 *
>> > +	 * Once the complete list of Core/Xeon models is known
>> > +	 * it can be added here, and the Atom list removed.
>> > +	 */
>> > +	return 1;
> So instead of trying to sort out the erratum, could we not just generally make MPX 
> dependent on SMEP and be done with it? MPX is a sophisticated security feature, 
> and it makes little sense to not do SMEP if you have it available.
> 
> Anyone who is absolutely desperate to disable SMEP while enabling MPX is free to 
> step in and make his case.

My concern was not necessarily with folks booting with 'nosmep', but
with processors that have MPX present and SMEP fused off (or made
unavailable by a hypervisor) and which are unaffected by this issue.

People would have to be very careful to never create a processor which
did not have SMEP but did have MPX, since MPX would effectively be
unusable on such a processor.

  reply	other threads:[~2016-05-03 21:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-02 22:03 [PATCH] [RFC] x86: work around MPX Erratum Dave Hansen
2016-05-03  6:43 ` Ingo Molnar
2016-05-03 21:04   ` Dave Hansen [this message]
2016-05-03 21:12     ` Borislav Petkov
2016-05-03 21:28       ` Dave Hansen
2016-05-03 21:33         ` Linus Torvalds
2016-05-03 21:45         ` Borislav Petkov
2016-05-03 21:31     ` Andy Lutomirski
2016-05-03 21:39       ` Linus Torvalds
2016-05-03 21:44         ` Andy Lutomirski
2016-05-03 21:43       ` Dave Hansen
2016-05-03 21:53         ` Andy Lutomirski
2016-05-04  6:44           ` Ingo Molnar
2016-05-05 17:14             ` Andy Lutomirski
2016-05-05 18:40               ` Ingo Molnar
2016-05-06 19:01                 ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57291268.3060006@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox