From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756921AbcEDAZ5 (ORCPT ); Tue, 3 May 2016 20:25:57 -0400 Received: from mga09.intel.com ([134.134.136.24]:11045 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756826AbcEDAZz (ORCPT ); Tue, 3 May 2016 20:25:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,574,1455004800"; d="scan'208";a="945617871" Subject: Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface To: Mark Brown References: <1461911198-2895-1-git-send-email-baolu.lu@linux.intel.com> <1461911198-2895-2-git-send-email-baolu.lu@linux.intel.com> <20160502110001.GF6292@sirena.org.uk> <5728025E.9040902@linux.intel.com> <20160503114935.GO6292@sirena.org.uk> Cc: felipe.balbi@linux.intel.com, Mathias Nyman , Greg Kroah-Hartman , Lee Jones , Heikki Krogerus , Liam Girdwood , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Lu Baolu Message-ID: <5729418E.90909@linux.intel.com> Date: Wed, 4 May 2016 08:25:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160503114935.GO6292@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 05/03/2016 07:49 PM, Mark Brown wrote: > On Tue, May 03, 2016 at 09:43:58AM +0800, Lu Baolu wrote: >> On 05/02/2016 07:00 PM, Mark Brown wrote: >>> On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote: >>>> + gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS); >>>> + if (IS_ERR(gpiod)) >>>> + return PTR_ERR(gpiod); >>> This is clearly an inappropriate name for the signal in generic code, >>> it's specific to your use case. >> I will change the gpio name to "gpio". Is that okay? > Yes, that looks good (and lines up with DT so hopefully the code can be > shared). Fair enough. Thanks. Best regards, Lu Baolu