From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757172AbcEDHa4 (ORCPT ); Wed, 4 May 2016 03:30:56 -0400 Received: from nat-hk.nvidia.com ([203.18.50.4]:4945 "EHLO hkmmgate102.nvidia.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751478AbcEDHaz convert rfc822-to-8bit (ORCPT ); Wed, 4 May 2016 03:30:55 -0400 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Wed, 04 May 2016 00:30:51 -0700 Message-ID: <5729A592.30407@nvidia.com> Date: Wed, 4 May 2016 15:32:34 +0800 From: Wei Ni User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thierry Reding CC: , , , , Subject: Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node References: <1462266577-951-1-git-send-email-wni@nvidia.com> <20160503152111.GC19539@ulmo.ba.sec> <57295DAF.1050800@nvidia.com> In-Reply-To: <57295DAF.1050800@nvidia.com> X-Originating-IP: [10.19.224.146] X-ClientProxiedBy: HKMAIL101.nvidia.com (10.18.16.10) To HKMAIL101.nvidia.com (10.18.16.10) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年05月04日 10:25, Wei Ni wrote: > > > On 2016年05月03日 23:21, Thierry Reding wrote: >> * PGP Signed by an unknown key >> >> On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote: >>> This patch changes the compatible of Tegra132 fuse node >>> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse". >>> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for >>> Tegra132, the fuse driver can't find the corresponding node. >> >> Okay, that's not really a good reason to modify the DTS. What we should >> do instead is make sure that the OF table contains the entry on Tegra132 >> builds. Unless the IP block really is different and Tegra124 and >> Tegra132 aren't compatible in this regard after all. >> >> In the latter case the commit message should reflect the real reason. Hi Thierry, I read the Documentation/devicetree/bindings/fuse/nvidia,tegra20-fuse.txt, it has description: - compatible : For Tegra20, must contain "nvidia,tegra20-efuse". For Tegra30, must contain "nvidia,tegra30-efuse". For Tegra114, must contain "nvidia,tegra114-efuse". For Tegra124, must contain "nvidia,tegra124-efuse". Otherwise, must contain "nvidia,-efuse", plus one of the above, where is tegra132. It mean for Tegra132, it should use "nvidia,tegra132-efuse". So if we don't change the DTS file, I need to fix the OF table in the driver and update the of-bindings, is it right? Wei. > > Hi Thierry, > > The fuse driver fuse-tegra.c has following OF table: > #ifdef CONFIG_ARCH_TEGRA_132_SOC > { .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc }, > #endif > #ifdef CONFIG_ARCH_TEGRA_124_SOC > { .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc }, > #endif > > It defined "nvidia,tegra124-efuse" under CONFIG_ARCH_TEGRA_124_SOC, so if we > don't change the DTS file, we should change it as: > -#ifdef CONFIG_ARCH_TEGRA_132_SOC > - { .compatible = "nvidia,tegra132-efuse", .data = &tegra124_fuse_soc }, > -#endif > -#ifdef CONFIG_ARCH_TEGRA_124_SOC > +#if defined CONFIG_ARCH_TEGRA_124_SOC || defined CONFIG_ARCH_TEGRA_132_SOC > { .compatible = "nvidia,tegra124-efuse", .data = &tegra124_fuse_soc }, > #endif > #ifdef CONFIG_ARCH_TEGRA_114_SOC > > I will send it out. > >> >> Thierry >> >> * Unknown Key >> * 0x7F3EB3A1 >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >