From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757597AbcEDIHu (ORCPT ); Wed, 4 May 2016 04:07:50 -0400 Received: from nat-hk.nvidia.com ([203.18.50.4]:15815 "EHLO hkmmgate101.nvidia.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756983AbcEDIHn convert rfc822-to-8bit (ORCPT ); Wed, 4 May 2016 04:07:43 -0400 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Wed, 04 May 2016 01:07:40 -0700 Subject: Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed To: Felipe Balbi References: <1461321780-3226-1-git-send-email-jilin@nvidia.com> <87bn51uagb.fsf@intel.com> <571E0058.6020007@nvidia.com> <87r3dtrj7b.fsf@intel.com> <571F2BA3.6040209@nvidia.com> <871t5plya5.fsf@intel.com> <57234522.9000607@nvidia.com> <87bn4siq5c.fsf@intel.com> CC: , From: Jim Lin Message-ID: <5729ADC9.3030704@nvidia.com> Date: Wed, 4 May 2016 16:07:37 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <87bn4siq5c.fsf@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.19.108.174] X-ClientProxiedBy: DRBGMAIL102.nvidia.com (10.18.16.21) To HKMAIL103.nvidia.com (10.18.16.12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年04月29日 19:57, Felipe Balbi wrote: > * PGP Signed by an unknown key > > > Hi, > > Jim Lin writes: >> On 2016年04月28日 20:21, Felipe Balbi wrote: >>>> I also attach git log of system/core/adb/usb_linux_client.cpp of Android >>>> N for your reference. >>>> " >>>> Author: Badhri Jagan Sridharan >>>> Date: Mon Oct 5 13:04:03 2015 -0700 >>>> >>>> adbd: Add os descriptor support for adb. >>>> >>>> Eventhough windows does not rely on extended os >>>> descriptor for adbd, when android usb device is >>>> configures as a composite device such as mtp+adb, >>>> windows discards the extended os descriptor even >>>> if one of the USB function fails to send >>>> the extended compat descriptor. This results in automatic >>>> install of MTP driverto fail when Android device is in >>>> "File Transfer" mode with adb enabled. >>>> >>>> https://msdn.microsoft.com/en-us/library/windows/hardware/gg463179.aspx >>>> " >>> Okay, cool. Can you check that you're limitting your controller's speed >>> to high-speed ? >>> >> Let's focus on original patch. >> Could you help to explain why we need below d->Reserved1 checking? >> Now the question is that >> >> https://msdn.microsoft.com/en-us/library/windows/hardware/gg463179.aspx >> >> Page 7 of OS_Desc_CompatID.doc >> defines reserved field to be 1 and >> below code will think that os_desc is invalid because d->Reserved1 is 1. >> >> >> In f_fs.c >> " >> static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, >> struct usb_os_desc_header *h, void *data, >> unsigned len, void *priv) >> { >> struct ffs_data *ffs = priv; >> u8 length; >> >> ENTER(); >> >> switch (type) { >> case FFS_OS_DESC_EXT_COMPAT: { >> struct usb_ext_compat_desc *d = data; >> int i; >> >> if (len < sizeof(*d) || >> d->bFirstInterfaceNumber >= ffs->interfaces_count || >> d->Reserved1) >> return -EINVAL; >> " > that's fine, but this is only failing because something else is > returning the wrong set of descriptors (SS vs HS). That's the bug we > want to fix, not work around it. > Thanks. --nvpublic