From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752471AbcEDLhc (ORCPT <rfc822;w@1wt.eu>);
	Wed, 4 May 2016 07:37:32 -0400
Received: from szxga01-in.huawei.com ([58.251.152.64]:23817 "EHLO
	szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750879AbcEDLha (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 4 May 2016 07:37:30 -0400
Subject: Re: [PATCH v6 00/21] Add HiSilicon RoCE driver
To: <leon@kernel.org>
References: <1461845396-61306-1-git-send-email-oulijun@huawei.com>
 <20160503184834.GD29160@leon.nu>
CC: <dledford@redhat.com>, <sean.hefty@intel.com>, <hal.rosenstock@gmail.com>,
        <davem@davemloft.net>, <jeffrey.t.kirsher@intel.com>,
        <jiri@mellanox.com>, <ogerlitz@mellanox.com>,
        <linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <netdev@vger.kernel.org>, <gongyangming@huawei.com>,
        <xiaokun@huawei.com>, <tangchaofei@huawei.com>,
        <haifeng.wei@huawei.com>, <yisen.zhuang@huawei.com>,
        <yankejian@huawei.com>, <charles.chenxin@huawei.com>,
        <linuxarm@huawei.com>
From: oulijun <oulijun@huawei.com>
Message-ID: <5729DD93.3000500@huawei.com>
Date: Wed, 4 May 2016 19:31:31 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160503184834.GD29160@leon.nu>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.61.25.147]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020201.5729DD9F.0056,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-06-18 04:22:30,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: b754c24034fc678921dceeef9b7dfbf1
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016/5/4 2:48, Leon Romanovsky wrote:
> On Thu, Apr 28, 2016 at 08:09:35PM +0800, Lijun Ou wrote:
>> The HiSilicon Network Substem is a long term evolution IP which is
>> supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network
>> Sybsystem) also has a hardware support of performing RDMA with
>> RoCEE.
>> The driver for HiSilicon RoCEE(RoCE Engine) is a platform driver and
>> will support mulitple versions of SOCs in future. This version of driver
>> is meant to support Hip06 SoC(which confirms to RoCEEv1 hardware
>> specifications).
> 
> Please read Dave's comment [1], it is valuable for your code as
> well.
> 
> * Please use 'bool' and "true/false"
> 
Yes, i see. thanks

Thanks
Lijun Ou
> [1] http://marc.info/?l=linux-rdma&m=146229367301442&w=2
> 
> Thanks
>