From: Adrian Hunter <adrian.hunter@intel.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Shawn Lin <shawn.lin@rock-chips.com>
Cc: "Jaehoon Chung" <jh80.chung@samsung.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>,
"Rob Herring" <robh+dt@kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Doug Anderson" <dianders@chromium.org>,
"Heiko Stuebner" <heiko@sntech.de>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 3/6] mmc: core: implement enhanced strobe support
Date: Wed, 4 May 2016 15:07:01 +0300 [thread overview]
Message-ID: <5729E5E5.6000409@intel.com> (raw)
In-Reply-To: <CAPDyKFogNjwNs+fKPaah_X=AfSgtXUwefzon+ZQ2a2Va5Om5Nw@mail.gmail.com>
>> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
>> index 4bc48f1..7e94b9d 100644
>> --- a/drivers/mmc/core/bus.c
>> +++ b/drivers/mmc/core/bus.c
>> @@ -332,12 +332,13 @@ int mmc_add_card(struct mmc_card *card)
>> mmc_card_ddr52(card) ? "DDR " : "",
>> type);
>> } else {
>> - pr_info("%s: new %s%s%s%s%s card at address %04x\n",
>> + pr_info("%s: new %s%s%s%s%s%s card at address %04x\n",
>> mmc_hostname(card->host),
>> mmc_card_uhs(card) ? "ultra high speed " :
>> (mmc_card_hs(card) ? "high speed " : ""),
>> mmc_card_hs400(card) ? "HS400 " :
>> (mmc_card_hs200(card) ? "HS200 " : ""),
>> + mmc_card_hs400es(card) ? "Enhanced strobe" : "",
>
> I am not sure this informations should be printed. It's still and
> HS400 card, there is no performance impact, right?
I actually asked for that I think. HS400ES does not need re-tuning so there
is a performance and behavioural change which I think it is very useful to
know. Kernels which don't support HS400ES will show "HS400" whereas kernels
which do support it will show something different.
next prev parent reply other threads:[~2016-05-04 13:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 2:42 [PATCH v2 0/6] Add enhanced strobe support for emmc version 5.1 or later Shawn Lin
2016-04-29 2:46 ` [PATCH v2 1/6] Documentation: mmc: add mmc-hs400-enhanced-strobe Shawn Lin
2016-05-03 17:05 ` Rob Herring
2016-04-29 2:46 ` [PATCH v2 2/6] mmc: core: add mmc-hs400-enhanced-strobe support Shawn Lin
2016-05-04 8:12 ` Ulf Hansson
2016-05-04 9:19 ` Shawn Lin
2016-04-29 2:47 ` [PATCH v2 3/6] mmc: core: implement enhanced strobe support Shawn Lin
2016-05-04 12:02 ` Ulf Hansson
2016-05-04 12:07 ` Adrian Hunter [this message]
2016-05-05 2:16 ` Shawn Lin
2016-05-09 11:56 ` Adrian Hunter
2016-05-10 8:29 ` Shawn Lin
2016-04-29 2:48 ` [PATCH v2 4/6] mmc: debugfs: add HS400 enhanced strobe description Shawn Lin
2016-05-09 12:00 ` Adrian Hunter
2016-04-29 2:48 ` [PATCH v2 5/6] mmc: sdhci: implement enhanced strobe callback Shawn Lin
2016-05-09 12:02 ` Adrian Hunter
2016-04-29 2:48 ` [PATCH v2 6/6] mmc: sdhci-of-arasan: overwrite " Shawn Lin
2016-04-29 16:01 ` Sören Brinkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5729E5E5.6000409@intel.com \
--to=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=heiko@sntech.de \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=soren.brinkmann@xilinx.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox