From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753578AbcEDSya (ORCPT ); Wed, 4 May 2016 14:54:30 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:40163 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753041AbcEDSy1 (ORCPT ); Wed, 4 May 2016 14:54:27 -0400 Subject: Re: [PATCH 3/4] rpmsg: add helper macro module_rpmsg_driver To: "Andrew F. Davis" , Ohad Ben-Cohen , Bjorn Andersson , Jonathan Corbet References: <1462386855-17381-1-git-send-email-afd@ti.com> <1462386855-17381-3-git-send-email-afd@ti.com> CC: , , From: Suman Anna Message-ID: <572A455F.7040306@ti.com> Date: Wed, 4 May 2016 13:54:23 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <1462386855-17381-3-git-send-email-afd@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Andrew, On 05/04/2016 01:34 PM, Andrew F. Davis wrote: > This patch introduces the module_rpmsg_driver macro which is a > convenience macro for rpmsg driver modules similar to > module_platform_driver. It is intended to be used by drivers which > init/exit section does nothing but register/unregister the rpmsg driver. > By using this macro it is possible to eliminate a few lines of > boilerplate code per rpmsg driver. > > Signed-off-by: Andrew F. Davis > --- > include/linux/rpmsg.h | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h > index 78e45ce..ada50ff 100644 > --- a/include/linux/rpmsg.h > +++ b/include/linux/rpmsg.h > @@ -177,13 +177,23 @@ struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_channel *, > int > rpmsg_send_offchannel_raw(struct rpmsg_channel *, u32, u32, void *, int, bool); > > -/* > - * use a macro to avoid include chaining to get THIS_MODULE > - */ > +/* use a macro to avoid include chaining to get THIS_MODULE */ This change does not belong to this patch, the modified lines were introduced in patch 1, so please correct it in that patch. regards Suman > #define register_rpmsg_driver(drv) \ > __register_rpmsg_driver(drv, THIS_MODULE) > > /** > + * module_rpmsg_driver() - Helper macro for registering an rpmsg driver > + * @__rpmsg_driver: rpmsg_driver struct > + * > + * Helper macro for rpmsg drivers which do not do anything special in module > + * init/exit. This eliminates a lot of boilerplate. Each module may only > + * use this macro once, and calling it replaces module_init() and module_exit() > + */ > +#define module_rpmsg_driver(__rpmsg_driver) \ > + module_driver(__rpmsg_driver, register_rpmsg_driver, \ > + unregister_rpmsg_driver) > + > +/** > * rpmsg_send() - send a message across to the remote processor > * @rpdev: the rpmsg channel > * @data: payload of message >