public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Andrew F. Davis" <afd@ti.com>
To: Suman Anna <s-anna@ti.com>, Ohad Ben-Cohen <ohad@wizery.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>
Cc: <linux-remoteproc@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] rpmsg: drop owner assignment from spi_drivers
Date: Wed, 4 May 2016 13:57:04 -0500	[thread overview]
Message-ID: <572A4600.2080300@ti.com> (raw)
In-Reply-To: <572A45AA.4020303@ti.com>

On 05/04/2016 01:55 PM, Suman Anna wrote:
> On 05/04/2016 01:34 PM, Andrew F. Davis wrote:
>> An rpmsg_driver does not need to set an owner, it will be populated by
>> the driver core.
> 
> spi_drivers in patch subject??
> 

copy/paste error, this is all based on my SPI patches that do this same
thing to that subsystem. Will fix.

Thanks,
Andrew

> regards
> Suman
> 
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>>  Documentation/rpmsg.txt             | 1 -
>>  samples/rpmsg/rpmsg_client_sample.c | 1 -
>>  2 files changed, 2 deletions(-)
>>
>> diff --git a/Documentation/rpmsg.txt b/Documentation/rpmsg.txt
>> index f7edc3a..1d88426 100644
>> --- a/Documentation/rpmsg.txt
>> +++ b/Documentation/rpmsg.txt
>> @@ -249,7 +249,6 @@ MODULE_DEVICE_TABLE(rpmsg, rpmsg_driver_sample_id_table);
>>  
>>  static struct rpmsg_driver rpmsg_sample_client = {
>>  	.drv.name	= KBUILD_MODNAME,
>> -	.drv.owner	= THIS_MODULE,
>>  	.id_table	= rpmsg_driver_sample_id_table,
>>  	.probe		= rpmsg_sample_probe,
>>  	.callback	= rpmsg_sample_cb,
>> diff --git a/samples/rpmsg/rpmsg_client_sample.c b/samples/rpmsg/rpmsg_client_sample.c
>> index 59b1344..82ed288 100644
>> --- a/samples/rpmsg/rpmsg_client_sample.c
>> +++ b/samples/rpmsg/rpmsg_client_sample.c
>> @@ -77,7 +77,6 @@ MODULE_DEVICE_TABLE(rpmsg, rpmsg_driver_sample_id_table);
>>  
>>  static struct rpmsg_driver rpmsg_sample_client = {
>>  	.drv.name	= KBUILD_MODNAME,
>> -	.drv.owner	= THIS_MODULE,
>>  	.id_table	= rpmsg_driver_sample_id_table,
>>  	.probe		= rpmsg_sample_probe,
>>  	.callback	= rpmsg_sample_cb,
>>
> 

  reply	other threads:[~2016-05-04 18:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04 18:34 [PATCH 1/4] rpmsg: add THIS_MODULE to rpmsg_driver in rpmsg core Andrew F. Davis
2016-05-04 18:34 ` [PATCH 2/4] rpmsg: drop owner assignment from spi_drivers Andrew F. Davis
2016-05-04 18:55   ` Suman Anna
2016-05-04 18:57     ` Andrew F. Davis [this message]
2016-05-04 18:34 ` [PATCH 3/4] rpmsg: add helper macro module_rpmsg_driver Andrew F. Davis
2016-05-04 18:54   ` Suman Anna
2016-05-04 18:58     ` Andrew F. Davis
2016-05-04 18:34 ` [PATCH 4/4] rpmsg: use module_rpmsg_driver in existing drivers and examples Andrew F. Davis
2016-05-04 18:56 ` [PATCH 1/4] rpmsg: add THIS_MODULE to rpmsg_driver in rpmsg core Suman Anna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572A4600.2080300@ti.com \
    --to=afd@ti.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=ohad@wizery.com \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox