From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754199AbcEDS5J (ORCPT ); Wed, 4 May 2016 14:57:09 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:53618 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752311AbcEDS5H (ORCPT ); Wed, 4 May 2016 14:57:07 -0400 Subject: Re: [PATCH 2/4] rpmsg: drop owner assignment from spi_drivers To: Suman Anna , Ohad Ben-Cohen , Bjorn Andersson , Jonathan Corbet References: <1462386855-17381-1-git-send-email-afd@ti.com> <1462386855-17381-2-git-send-email-afd@ti.com> <572A45AA.4020303@ti.com> CC: , , From: "Andrew F. Davis" Message-ID: <572A4600.2080300@ti.com> Date: Wed, 4 May 2016 13:57:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <572A45AA.4020303@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/04/2016 01:55 PM, Suman Anna wrote: > On 05/04/2016 01:34 PM, Andrew F. Davis wrote: >> An rpmsg_driver does not need to set an owner, it will be populated by >> the driver core. > > spi_drivers in patch subject?? > copy/paste error, this is all based on my SPI patches that do this same thing to that subsystem. Will fix. Thanks, Andrew > regards > Suman > >> >> Signed-off-by: Andrew F. Davis >> --- >> Documentation/rpmsg.txt | 1 - >> samples/rpmsg/rpmsg_client_sample.c | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/Documentation/rpmsg.txt b/Documentation/rpmsg.txt >> index f7edc3a..1d88426 100644 >> --- a/Documentation/rpmsg.txt >> +++ b/Documentation/rpmsg.txt >> @@ -249,7 +249,6 @@ MODULE_DEVICE_TABLE(rpmsg, rpmsg_driver_sample_id_table); >> >> static struct rpmsg_driver rpmsg_sample_client = { >> .drv.name = KBUILD_MODNAME, >> - .drv.owner = THIS_MODULE, >> .id_table = rpmsg_driver_sample_id_table, >> .probe = rpmsg_sample_probe, >> .callback = rpmsg_sample_cb, >> diff --git a/samples/rpmsg/rpmsg_client_sample.c b/samples/rpmsg/rpmsg_client_sample.c >> index 59b1344..82ed288 100644 >> --- a/samples/rpmsg/rpmsg_client_sample.c >> +++ b/samples/rpmsg/rpmsg_client_sample.c >> @@ -77,7 +77,6 @@ MODULE_DEVICE_TABLE(rpmsg, rpmsg_driver_sample_id_table); >> >> static struct rpmsg_driver rpmsg_sample_client = { >> .drv.name = KBUILD_MODNAME, >> - .drv.owner = THIS_MODULE, >> .id_table = rpmsg_driver_sample_id_table, >> .probe = rpmsg_sample_probe, >> .callback = rpmsg_sample_cb, >> >