public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: "Luck, Tony" <tony.luck@intel.com>, "bp@alien8.de" <bp@alien8.de>
Cc: "dougthompson@xmission.com" <dougthompson@xmission.com>,
	"mchehab@osg.samsung.com" <mchehab@osg.samsung.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ie31200_edac: add skylake support
Date: Wed, 4 May 2016 15:03:44 -0400	[thread overview]
Message-ID: <572A4790.9080501@akamai.com> (raw)
In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F3A0BE118@ORSMSX114.amr.corp.intel.com>



On 05/04/2016 01:44 PM, Luck, Tony wrote:
>> I've verified that the 'ce_count' is correctly incrementing with bad dimms.
> Did you re-test on at least one of the previous 3 generations of CPUs supported
> by this driver?  All would be nice, but the bulk of the opportunities for cut&paste
> errors seem to be in code that looks like:
>
> 	if (Skylake)
> 		do new thing
> 	else
> 		do old thing
>
> so if one of them still works, it's likely they all do.
>
> -Tony

Hi Tony,

I verified that at least the memory sizes, ie the 'size_mb' files
are correct on the old h/w. I don't have bad dimms atm to test
the old h/w error paths though. That said this driver does get a
lot indirect testing here (just from being loaded), - so I would
likely find out if there were regressions.

Thanks,

-Jason

  reply	other threads:[~2016-05-04 19:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-04 13:38 [PATCH] ie31200_edac: add skylake support Jason Baron
2016-05-04 17:44 ` Luck, Tony
2016-05-04 19:03   ` Jason Baron [this message]
2016-05-04 20:15     ` Luck, Tony
2016-05-06  8:02 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572A4790.9080501@akamai.com \
    --to=jbaron@akamai.com \
    --cc=bp@alien8.de \
    --cc=dougthompson@xmission.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@osg.samsung.com \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox