From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753176AbcEDTDt (ORCPT ); Wed, 4 May 2016 15:03:49 -0400 Received: from prod-mail-xrelay05.akamai.com ([23.79.238.179]:47567 "EHLO prod-mail-xrelay05.akamai.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751056AbcEDTDr (ORCPT ); Wed, 4 May 2016 15:03:47 -0400 Subject: Re: [PATCH] ie31200_edac: add skylake support To: "Luck, Tony" , "bp@alien8.de" References: <1462369139-30528-1-git-send-email-jbaron@akamai.com> <3908561D78D1C84285E8C5FCA982C28F3A0BE118@ORSMSX114.amr.corp.intel.com> CC: "dougthompson@xmission.com" , "mchehab@osg.samsung.com" , "linux-edac@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Jason Baron Message-ID: <572A4790.9080501@akamai.com> Date: Wed, 4 May 2016 15:03:44 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F3A0BE118@ORSMSX114.amr.corp.intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/04/2016 01:44 PM, Luck, Tony wrote: >> I've verified that the 'ce_count' is correctly incrementing with bad dimms. > Did you re-test on at least one of the previous 3 generations of CPUs supported > by this driver? All would be nice, but the bulk of the opportunities for cut&paste > errors seem to be in code that looks like: > > if (Skylake) > do new thing > else > do old thing > > so if one of them still works, it's likely they all do. > > -Tony Hi Tony, I verified that at least the memory sizes, ie the 'size_mb' files are correct on the old h/w. I don't have bad dimms atm to test the old h/w error paths though. That said this driver does get a lot indirect testing here (just from being loaded), - so I would likely find out if there were regressions. Thanks, -Jason