From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755680AbcEECAw (ORCPT ); Wed, 4 May 2016 22:00:52 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:47694 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbcEECAu (ORCPT ); Wed, 4 May 2016 22:00:50 -0400 Message-ID: <572AA92F.8090802@huawei.com> Date: Thu, 5 May 2016 10:00:15 +0800 From: Hou Pengyang User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Jaegeuk Kim CC: , , , wangbintian 00221568 Subject: Re: [f2fs-dev] [PATCH 11/11] f2fs: retry to truncate blocks in -ENOMEM case References: <1462299708-67906-1-git-send-email-jaegeuk@kernel.org> <1462299708-67906-11-git-send-email-jaegeuk@kernel.org> In-Reply-To: <1462299708-67906-11-git-send-email-jaegeuk@kernel.org> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.95.59] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090202.572AA939.0049,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 0dc88210f93267647b3f19ac3f5b0753 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/5/4 2:21, Jaegeuk Kim wrote: > This patch modifies to retry truncating node blocks in -ENOMEM case. > Hi, Kim. in this patch, I think there is NO chance to retry for -ENOMEM. This is because if exist_written_data returns false, we can confirm that this inode has been released from orphan radix-tree: f2fs_evict_inode ---> remove_inode_page ---> truncate_node ---> remove_orphan_inode On this condition, err is 0, So it won't enter: if (err && err != -ENOENT) { ... } sequentially, there is no chance to truncate node blocks again. I miss something else? How about this patch? --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -345,6 +345,7 @@ void f2fs_evict_inode(struct inode *inode) set_inode_flag(fi, FI_NO_ALLOC); i_size_write(inode, 0); +retry: if (F2FS_HAS_BLOCKS(inode)) err = f2fs_truncate(inode, true); @@ -354,6 +355,11 @@ void f2fs_evict_inode(struct inode *inode) f2fs_unlock_op(sbi); } + if (err == -ENOMEM) { + err = 0; + goto retry; + } + sb_end_intwrite(inode->i_sb); no_delete: stat_dec_inline_xattr(inode); > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/inode.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c > index f4ac851..5cccd7a 100644 > --- a/fs/f2fs/inode.c > +++ b/fs/f2fs/inode.c > @@ -344,7 +344,7 @@ void f2fs_evict_inode(struct inode *inode) > sb_start_intwrite(inode->i_sb); > set_inode_flag(fi, FI_NO_ALLOC); > i_size_write(inode, 0); > - > +retry: > if (F2FS_HAS_BLOCKS(inode)) > err = f2fs_truncate(inode, true); > > @@ -374,6 +374,11 @@ no_delete: > > if (err && err != -ENOENT) { > if (!exist_written_data(sbi, inode->i_ino, ORPHAN_INO)) { > + /* give more chances, if ENOMEM case */ > + if (err == -ENOMEM) { > + err = 0; > + goto retry; > + } > /* > * get here because we failed to release resource > * of inode previously, reminder our user to run fsck >