From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753028AbcEEGSt (ORCPT ); Thu, 5 May 2016 02:18:49 -0400 Received: from regular1.263xmail.com ([211.150.99.137]:33010 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbcEEGSr (ORCPT ); Thu, 5 May 2016 02:18:47 -0400 X-263anti-spam: BIG:0;ABS:1;DNS:0;ATT:0;SPF:S;KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-KSVirus-check: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: denis@eukrea.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: <4e74784220bd9ff05722d89c8015d893> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH RESEND v3 1/2] drm: introduce bus_flags in drm_display_info To: Stefan Agner , dri-devel@lists.freedesktop.org, thierry.reding@gmail.com References: <1462424940-5164-1-git-send-email-stefan@agner.ch> <1462424940-5164-2-git-send-email-stefan@agner.ch> Cc: jianwei.wang.chn@gmail.com, meng.yi@nxp.com, linux@arm.linux.org.uk, eric@eukrea.com, alison.wang@freescale.com, daniel.vetter@ffwll.ch, linux-kernel@vger.kernel.org, denis@eukrea.com From: Mark yao Message-ID: <572AE5BA.3060003@rock-chips.com> Date: Thu, 5 May 2016 14:18:34 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1462424940-5164-2-git-send-email-stefan@agner.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefan Actually, the pixel clock or data enable polarity are also needed by drm/rockchip, but I have a question: why not add these polarity into drm_display_mode->flags. drm_display_mode->flags has hsync and vsync polarity, I think it's cool that add pixel clock or data enable polarity on drm_display_mode->flags. The polarity seems should be used on crtc, but crtc can't direct get the panel, save polarity on panel_desc means need more work to transmit it to crtc. Thanks. On 2016年05月05日 13:08, Stefan Agner wrote: > Introduce bus_flags to specify display bus properties like signal > polarities. This is useful for parallel display buses, e.g. to > specify the pixel clock or data enable polarity. > > Suggested-by: Thierry Reding > Acked-by: Philipp Zabel > Acked-by: Manfred Schlaegl > Acked-by: Daniel Vetter > Signed-off-by: Stefan Agner > --- > drivers/gpu/drm/panel/panel-simple.c | 2 ++ > include/drm/drm_crtc.h | 9 +++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index ceb2048..77ae07f 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -72,6 +72,7 @@ struct panel_desc { > } delay; > > u32 bus_format; > + u32 bus_flags; > }; > > struct panel_simple { > @@ -144,6 +145,7 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel) > if (panel->desc->bus_format) > drm_display_info_set_bus_formats(&connector->display_info, > &panel->desc->bus_format, 1); > + connector->display_info.bus_flags = panel->desc->bus_flags; > > return num; > } > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index 4acdaf5..d1559cd 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -118,6 +118,14 @@ enum subpixel_order { > #define DRM_COLOR_FORMAT_RGB444 (1<<0) > #define DRM_COLOR_FORMAT_YCRCB444 (1<<1) > #define DRM_COLOR_FORMAT_YCRCB422 (1<<2) > + > +#define DRM_BUS_FLAG_DE_LOW (1<<0) > +#define DRM_BUS_FLAG_DE_HIGH (1<<1) > +/* drive data on pos. edge */ > +#define DRM_BUS_FLAG_PIXDATA_POSEDGE (1<<2) > +/* drive data on neg. edge */ > +#define DRM_BUS_FLAG_PIXDATA_NEGEDGE (1<<3) > + > /* > * Describes a given display (e.g. CRT or flat panel) and its limitations. > */ > @@ -139,6 +147,7 @@ struct drm_display_info { > > const u32 *bus_formats; > unsigned int num_bus_formats; > + u32 bus_flags; > > /* Mask of supported hdmi deep color modes */ > u8 edid_hdmi_dc_modes; -- Ｍark Yao