From: Jon Hunter <jonathanh@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>, <linux-usb@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice
Date: Thu, 5 May 2016 18:10:04 +0100 [thread overview]
Message-ID: <572B7E6C.5070201@nvidia.com> (raw)
In-Reply-To: <572B7D48.6010807@nvidia.com>
On 05/05/16 18:05, Jon Hunter wrote:
[snip]
> I spent a bit of time looking at this to figure out what it is doing. Can we simply
> this a bit as follows (limited testing so far) ...
>
> Cheers
> Jon
>
> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> index c1c1024a054c..70501053e1ec 100644
> --- a/drivers/usb/host/ehci-tegra.c
> +++ b/drivers/usb/host/ehci-tegra.c
> @@ -81,15 +81,25 @@ static int tegra_reset_usb_controller(struct platform_device *pdev)
> struct usb_hcd *hcd = platform_get_drvdata(pdev);
> struct tegra_ehci_hcd *tegra =
> (struct tegra_ehci_hcd *)hcd_to_ehci(hcd)->priv;
> + bool has_utmi_pad_registers = false;
> + dev_info(&pdev->dev, "%s-%d\n", __func__, __LINE__);
Oops, some left over debug I meant to remove :-p
Jon
next prev parent reply other threads:[~2016-05-05 17:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 14:39 [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset Thierry Reding
2016-05-04 14:40 ` [PATCH v3 2/2] usb: host: ehci-tegra: Avoid getting the same reset twice Thierry Reding
2016-05-04 17:22 ` Philipp Zabel
2016-05-04 20:16 ` Thierry Reding
2016-05-04 17:23 ` Stephen Warren
2016-05-04 20:25 ` Thierry Reding
2016-05-05 8:05 ` Hans de Goede
2016-05-05 16:00 ` Stephen Warren
2016-05-05 17:12 ` Hans de Goede
2016-05-05 17:05 ` Jon Hunter
2016-05-05 17:10 ` Jon Hunter [this message]
2016-05-04 14:57 ` [PATCH v3 1/2] usb: host: ehci-tegra: Grab the correct UTMI pads reset Greg Kroah-Hartman
2016-05-04 15:26 ` Thierry Reding
2016-05-05 16:05 ` Tuomas Tynkkynen
2016-05-04 17:14 ` Stephen Warren
2016-05-04 20:30 ` Thierry Reding
2016-05-05 7:39 ` Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572B7E6C.5070201@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=gnurou@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=stern@rowland.harvard.edu \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox