From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754684AbcEEROH (ORCPT ); Thu, 5 May 2016 13:14:07 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34624 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751217AbcEEROF (ORCPT ); Thu, 5 May 2016 13:14:05 -0400 Subject: Re: [PATCH v2 03/15] MIPS: PCI: Compatibility with ARM-like PCI host drivers To: Paul Burton References: <1454499045-5020-1-git-send-email-paul.burton@imgtec.com> <1454499045-5020-4-git-send-email-paul.burton@imgtec.com> <56FB0D90.8000200@gmail.com> <20160404100940.GA21568@NP-P-BURTON> <572AA3A0.5080201@gmail.com> <20160505110230.GA8303@NP-P-BURTON> Cc: linux-mips@linux-mips.org, Ralf Baechle , Joshua Kinard , Lorenzo Pieralisi , Bjorn Helgaas , Zubair Lutfullah Kakakhel , Jens Axboe , linux-kernel@vger.kernel.org, Yijing Wang , John Crispin , Yinghai Lu From: Florian Fainelli Message-ID: <572B7F56.20104@gmail.com> Date: Thu, 5 May 2016 10:13:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160505110230.GA8303@NP-P-BURTON> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/16 04:02, Paul Burton wrote: > On Wed, May 04, 2016 at 06:36:32PM -0700, Florian Fainelli wrote: >> Hi Paul, >> >> On 04/04/16 03:09, Paul Burton wrote: >>> Hi Florian, >>> >>> Just an FYI, the pcie-xilinx driver I wrote this for has since been >>> converted away from the ARM-like pci_common_init_dev & struct hw_pci to >>> use only functions provided by the core PCI subsystem[1]. As a result >>> I've stopped using this patch & don't plan to continue work on it. >>> Perhaps it would be cleanest to do a similar conversion for the driver >>> you're using? >> >> Yes, I did just that, but as of v4.6-rc6, I am seeing a bunch of >> undefined references while doing so: >> >> arch/mips/pci/built-in.o: In function `pcibios_enable_device': >> (.text+0x550): undefined reference to `pcibios_plat_dev_init' >> arch/mips/pci/built-in.o: In function `pcibios_init': >> pci.c:(.init.text+0x6c): undefined reference to `pcibios_map_irq' >> pci.c:(.init.text+0x78): undefined reference to `pcibios_map_irq' >> >> and this makes perfect sense because arch/mips/pci/pci.c is referencing >> those functions, while I did not add anything for BMIPS_GENERIC. >> >> At this point, I would very much prefer that the MIPS/Linux kernel did >> not rely on the different machines to provide those implementations >> (though it definitively is not a big deal to add them, it just feels >> unnecessary), I will try to cook a patch for that and provide dummy >> fallbacks. > > Hi Florian, > > I've done much the same for Boston already - do these patches work for > you? Yep, that's exactly what I needed, this worked great with the pcie-brcmstb.c driver, thanks! I can re-test them once you make a formal submission for the Boston board. Cheers! -- Florian