From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751575AbcEFFt6 (ORCPT ); Fri, 6 May 2016 01:49:58 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:54002 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbcEFFt4 (ORCPT ); Fri, 6 May 2016 01:49:56 -0400 Date: Fri, 06 May 2016 07:49:51 +0200 From: Krzysztof Opasiak Subject: Re: [PATCH 1/2] usb: configfs: allow UDC binding rule configured as binding to *any* UDC In-reply-to: <0C18FE92A7765D4EB9EE5D38D86A563A05D2D2BA@SHSMSX103.ccr.corp.intel.com> To: "Du, Changbin" , "balbi@kernel.org" Cc: "gregkh@linuxfoundation.org" , "corbet@lwn.net" , "linux-usb@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "Du, Changbin" , "Du@vger.kernel.org" Message-id: <572C307F.7090102@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-AuditID: cbfec7f5-f792a6d000001302-14-572c3080604f X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t/xq7oNBjrhBt/3Glkca3vCbvHk2jkm i40XjzNZPDnQzmixYsVORovmxevZLBa2LWGxuLxrDpvFomWtzA6cHjtn3WX3WLznJZPHplWd bB77564Bcvsms3p83iQXwBbFZZOSmpNZllqkb5fAlfFy3SXmgv08FS0znzA3MH7k7GLk5JAQ MJHo+trNDGGLSVy4t54NxBYSWMoo0TfHq4uRC8h+ziixY/oidpCEsECyxPT1rWC2iECwxNEb DSwQRdeZJB61n2AEcZgFPjBJ/DqyFsjh4GAT0JeYt0sUpIFXQEviT/92VhCbRUBVYnnTPUYQ W1QgQuLJ3JOMEDWCEj8m32MBaeUUCJP497MSxGQW0JO4f1ELpIJZQF5i85q3zBMYBWYhaZiF UDULSdUCRuZVjKKppckFxUnpuUZ6xYm5xaV56XrJ+bmbGCHh/3UH49JjVocYBTgYlXh4M05q hwuxJpYVV+YeYpTgYFYS4e3T0wkX4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjtz1/sQIYH0xJLU 7NTUgtQimCwTB6dUA6MebwezQba0ckTK9zxGloi613PSSs4+1WvZlZ58z9xKbvmp9skP/PrU RCW+fMzgXh5Xd3ti1ufLnKsYNkS531WTWjtbsmiGrZMxj9kmVreDqhIrVuVPOG5/4pmM9fqX XzcYssadiXdfN/VcmInaXCetCabPZ1/8tfWvPZec//Hp16Oa5u78v1WJpTgj0VCLuag4EQAv WcWrewIAAA== References: <1462244665-27681-1-git-send-email-changbin.du@intel.com> <1462244665-27681-2-git-send-email-changbin.du@intel.com> <5729AF76.7080508@samsung.com> <0C18FE92A7765D4EB9EE5D38D86A563A05D2CE79@SHSMSX103.ccr.corp.intel.com> <572AF6D5.9090406@samsung.com> <0C18FE92A7765D4EB9EE5D38D86A563A05D2D2BA@SHSMSX103.ccr.corp.intel.com> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2016 04:46 AM, Du, Changbin wrote: (...) >> Well, I'm not sure if any configfs interface has been proposed as easy >> to use from cmd line. I think they all has been proposed as *usable* >> from cmd line but not necessarily *easy to use*. >> >> That's why most of configfs clients has some support in userspace. For >> example for target there is a taget-cli and for usb gadget we have >> libusbg/libusbgx. >> > Glade to know this tool, it is much more easy to use than interact with sysfs. > I'd like use it. Just see you are the main contributor of this project. :) > That's true;) personally I would recommend you using libusbgx[1] instead of libusbg[2] as it is far more recent and usable (292 commits vs 128;) ) (...) >> >> What do you mean pseudo 'busy'? If we do: >> >> echo > UDC >> > Sorry, please ignore this. I find if no UDC available, the config will be queued > to a list, and will bind it when a UDC module install. So it is really busy. > >> then gadget should be really bound to some udc and potentially really busy. >> >>> In a word, this patch is just an improvement, not to fix any issues or >>> add new function. >> >> So it doesn't add any new functionality and breaks existing user space >> tools. >> Yes, currently it's true but it's a bug which I have fixed yesterday[3] Footnotes: 1 - https://github.com/libusbgx/libusbgx 2 - https://github.com/libusbg/libusbg 3 - http://marc.info/?l=linux-usb&m=146243801207458&w=2 Cheers, -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics