From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757587AbcEFGMi (ORCPT ); Fri, 6 May 2016 02:12:38 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:54782 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752531AbcEFGMf (ORCPT ); Fri, 6 May 2016 02:12:35 -0400 X-AuditID: cbfec7f4-f796c6d000001486-c8-572c35cadeda Subject: Re: [RFC v2 00/13] usb/mmc/power: Fix USB/LAN when TFTP booting To: Peter Chen , Rob Herring References: <1462451666-17945-1-git-send-email-k.kozlowski@samsung.com> <20160505224240.GA31429@rob-hp-laptop> <20160506054459.GA32359@shlinux2.ap.freescale.net> Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, Ulf Hansson , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Greg Kroah-Hartman , Mark Brown , hverkuil@xs4all.nl, tjakobi@math.uni-bielefeld.de, Bartlomiej Zolnierkiewicz , m.szyprowski@samsung.com From: Krzysztof Kozlowski Message-id: <572C35C8.9080709@samsung.com> Date: Fri, 06 May 2016 08:12:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 In-reply-to: <20160506054459.GA32359@shlinux2.ap.freescale.net> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t/xq7qnTHXCDXYu47LYOGM9q8XUh0/Y LCY9ec9sMf/IOVaLiSsnM1s0L17PZnFq8jMmi66rm9gsXr8wtNj0+BqrxeVdc9gsjvzvZ7T4 3HuE0WLG+X1MFouWtTJbrD1yl93i/54d7Band5dYtK3+wGpxfG24g4jHzll32T02r9Dy2LSq k83jzrU9bB77564BCi2p9/h3jN2jb8sqRo/Pm+Q8Tn39zB7AFcVlk5Kak1mWWqRvl8CVsfJK L2PBG56KVQs2sDUwTuXqYuTkkBAwkdg6rZcVwhaTuHBvPVsXIxeHkMBSRokLV26xQDjPGCUu nVnKBlIlLOAhcXrdfUYQW0TAVWJL2wQWuI69i9cxgjjMAvdZJDY8XcoOUsUmYCyxefkSoG4O Dl4BLYmJa7NAwiwCqhJvP6xhAbFFBSIkVq+7xgxi8woISvyYfA8szilgL3HsznpGkFZmAT2J +xe1QMLMAvISm9e8ZZ7AKDALSccshKpZSKoWMDKvYhRNLU0uKE5KzzXUK07MLS7NS9dLzs/d xAiJxi87GBcfszrEKMDBqMTDm3FSO1yINbGsuDL3EKMEB7OSCG+zsU64EG9KYmVValF+fFFp TmrxIUZpDhYlcd65u96HCAmkJ5akZqemFqQWwWSZODilGhgN5q2986B9Su3lsHMPt3mfce4/ zmS+6zfzm/a4yH+O9nUpRfsCtzpuenT+CMOpVevzX56WubYz7o2Mw/H5WxfmCplkbJJtXRj8 Mp6V7eul38+v11lZynyMrjroc+D3Su6Ffra7hXe3F5xa+3mxW/GXTUF1ndEN7aurV27tNFn1 1/ppRYb/Ma0DSizFGYmGWsxFxYkAxF6Z18ICAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2016 07:44 AM, Peter Chen wrote: > On Thu, May 05, 2016 at 05:42:40PM -0500, Rob Herring wrote: >> On Thu, May 05, 2016 at 02:34:13PM +0200, Krzysztof Kozlowski wrote: >>> Hi, >>> >>> This is a different, second try to fix usb3503+lan on Odroid U3 board >>> if it was initialized by bootloader (e.g. for TFTP boot). >>> >>> First version: >>> http://www.spinics.net/lists/linux-usb/msg140042.html >>> >>> >>> Problem >>> ======= >>> When Odroid U3 (usb3503 + smsc95xx + max77686) boots from network (TFTP), >>> the usb3503 and LAN smsc95xx do not show up in "lsusb". Hard-reset >>> is required, e.g. by suspend to RAM. The actual TFTP boot does >>> not have to happen. Just "usb start" from U-Boot is sufficient. >>> >>> From the schematics, the regulator is a supply only to LAN, however >>> without toggling it off/on, the usb3503 hub won appear neither. >>> >>> >>> Solution >>> ======== >>> This is very similar to the MMC pwrseq behavior so the idea is to: >>> 1. Move MMC pwrseq drivers to generic place, >> >> You can do that, but I'm going to NAK any use of pwrseq bindings outside >> of MMC. I think it is the wrong way to do things. The DT should describe >> the devices. If they happen to be "simple" then the core can walk the >> tree and do any setup. For example, look for "reset-gpios" and toggle >> that GPIO. There is no need for a special node. >> > > Oh, I am doing the same thing like this patch set doing. Shame on me that I did not use Google before starting the work. I could just extend your patchset. I think we can combine our efforts. Best regards, Krzysztof