From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756016AbcEFGPN (ORCPT ); Fri, 6 May 2016 02:15:13 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:52978 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751167AbcEFGPK (ORCPT ); Fri, 6 May 2016 02:15:10 -0400 X-AuditID: cbfec7f5-f792a6d000001302-6a-572c3669da6b Subject: Re: [RFC v2 02/13] power/mmc: Move pwrseq drivers to power/pwrseq To: Javier Martinez Canillas , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, Ulf Hansson , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Greg Kroah-Hartman , Mark Brown References: <1462451666-17945-1-git-send-email-k.kozlowski@samsung.com> <1462451666-17945-3-git-send-email-k.kozlowski@samsung.com> <4532bfb4-38f9-a61d-1d80-e5af18cd3d98@osg.samsung.com> Cc: tjakobi@math.uni-bielefeld.de, m.szyprowski@samsung.com, hverkuil@xs4all.nl, Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <572C3667.3090002@samsung.com> Date: Fri, 06 May 2016 08:15:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 In-reply-to: <4532bfb4-38f9-a61d-1d80-e5af18cd3d98@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrPIsWRmVeSWpSXmKPExsVy+t/xq7qZZjrhBov3W1lsnLGe1WLqwyds FpOevGe2mH/kHKvFxJWTmS2aF69nszg1+RmTxZu3a5gsXr8wtNj0+BqrxeVdc9gsjvzvZ7T4 3HuE0WLG+X1MFouWtTJbrD1yl93i9O4Si7bVH1gtjq8NdxD22DnrLrvH5hVaHptWdbJ53Lm2 h81j/9w1QKEl9R7/jrF7bOkHyvdtWcXo8XmTnMepr5/ZA7ijuGxSUnMyy1KL9O0SuDJ+HPvF WjCLp2J27132BsbnnF2MHBwSAiYSO7uZuxg5gUwxiQv31rN1MXJxCAksZZRYuG4KK0hCSOAZ o8TWiRwgtrCAl8TVJ3+ZQYpEBHpZJC6cO88E0bGPUeJW612wdmaBdqCOU7vZQFrYBIwlNi9f AmbzCmhJPDm7AcxmEVCVOLJkKyOILSoQIbF63TVmiBpBiR+T77GA2JwCzhJdDXfYQU5lFtCT uH9RCyTMLCAvsXnNW+YJjAKzkHTMQqiahaRqASPzKkbR1NLkguKk9FwjveLE3OLSvHS95Pzc TYyQaPy6g3HpMatDjAIcjEo8vBkntcOFWBPLiitzDzFKcDArifA2G+uEC/GmJFZWpRblxxeV 5qQWH2KU5mBREueduet9iJBAemJJanZqakFqEUyWiYNTqoFx7YFd5j8OTJyV45vmdGnmhQm/ M1/lun2dd0Jbg4F1viOb1K/lc0v/v51suqa0oq5l0sbw++cqVEuPP7904uz57zP5piu35jTd 1ax5OHtXX3WeavWdU108NXGHPlyd32z/MSDl2LE3EeYCXxmy799KkpQSZ+PaGmcixHD7m8xm 1wOH9pscaLi/QYmlOCPRUIu5qDgRAI19XhPCAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/2016 08:44 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> The MMC power sequence drivers are useful also outside of MMC world: for >> USB devices needed a hard-reset before probing. Before extending and >> re-using pwrseq drivers, move them to a new place. >> >> The commit does not introduce significant changes in the pwrseq drivers >> code so still all the functions are prefixed with "mmc_pwrseq". However >> the MMC-specific pwrseq functions has to be now exported and everything >> is hidden not by CONFIG_OF but by new CONFIG_POWER_SEQ option. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > [snip] > >> --- a/drivers/mmc/core/Kconfig >> +++ b/drivers/power/pwrseq/Kconfig >> @@ -1,7 +1,12 @@ >> -# >> -# MMC core configuration >> -# >> -config PWRSEQ_EMMC >> +menuconfig POWER_SEQ >> + default y if OF >> + bool "Hardware reset support for specific devices" >> + help >> + Provides drivers which reset the specific device before... >> + > > I think this text could be improved a little bit, maybe something like: > > "Provides drivers that implements specific power sequences for chips, > using the generic power sequence management interface". > > The rest looks good to me. > > Reviewed-by: Javier Martinez Canillas Yes, I wanted to code, not to focus on descriptions, so also commit messages should be extended. I'll fix this in next iteration. BR, Krzysztof