From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752596AbcEFGUY (ORCPT ); Fri, 6 May 2016 02:20:24 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:22912 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbcEFGUV (ORCPT ); Fri, 6 May 2016 02:20:21 -0400 X-AuditID: cbfec7f4-f796c6d000001486-56-572c37a1d581 Subject: Re: [RFC v2 05/13] power: pwrseq: Remove mmc prefix from mmc_pwrseq To: Javier Martinez Canillas , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, Ulf Hansson , Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse , Greg Kroah-Hartman , Mark Brown References: <1462451666-17945-1-git-send-email-k.kozlowski@samsung.com> <1462451666-17945-6-git-send-email-k.kozlowski@samsung.com> <48539995-2966-0df0-51db-e0c549a92880@osg.samsung.com> Cc: tjakobi@math.uni-bielefeld.de, m.szyprowski@samsung.com, hverkuil@xs4all.nl, Bartlomiej Zolnierkiewicz From: Krzysztof Kozlowski Message-id: <572C379F.6030504@samsung.com> Date: Fri, 06 May 2016 08:20:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 In-reply-to: <48539995-2966-0df0-51db-e0c549a92880@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t/xq7oLzXXCDS6vNLPYOGM9q8XUh0/Y LCY9ec9sMf/IOVaLiSsnM1s0L17PZnFq8jMmizdv1zBZvH5haLHp8TVWi8u75rBZHPnfz2jx ufcIo8WM8/uYLBYta2W2WHvkLrvF6d0lFm2rP7BaHF8b7iDssXPWXXaPzSu0PDat6mTzuHNt D5vH/rlrgEJL6j3+HWP32NIPlO/bsorR4/MmOY9TXz+zB3BHcdmkpOZklqUW6dslcGU8/MpW cIm94tEclQbGJWxdjJwcEgImEot+HGeEsMUkLtxbDxTn4hASWMoo8Wn1MijnGaPEjEmzWEGq hAV8JBreLmUESYgI9LJIXDh3ngmiah+jxIOHh8AcZoF2Romtp3aDLWETMJbYvBxiIa+AlsSk 83uBbA4OFgFVicaZSSBhUYEIidXrrjFDlAhK/Jh8jwXE5hRwluieM5cVpJxZQE/i/kUtkDCz gLzE5jVvmScwCsxC0jELoWoWkqoFjMyrGEVTS5MLipPScw31ihNzi0vz0vWS83M3MUJi8csO xsXHrA4xCnAwKvHwZpzUDhdiTSwrrsw9xCjBwawkwqtqphMuxJuSWFmVWpQfX1Sak1p8iFGa g0VJnHfurvchQgLpiSWp2ampBalFMFkmDk6pBsZl4eJP7qzuUk1eOnvN6gjGXAtvGabSVwue nc6tfqNhP62vXe6s2KNvimkv1j76sWReR02NoPXE33fU5t46o252Zfn1/oYbp1vn3puwNjcm auVhr6vsE1d3e2wwfbHM6FrRvxcLPx5Qqtz04+flg+fOrrwpHivrNvHdwcbrinZubMd8/oZE mecvUmIpzkg01GIuKk4EAHDUKHnBAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/2016 09:09 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/05/2016 08:34 AM, Krzysztof Kozlowski wrote: >> The "mmc" prefix is no longer needed after moving the pwrseq core code >> from mmc/ to power/. >> >> Signed-off-by: Krzysztof Kozlowski >> --- > > [snip] > >> diff --git a/drivers/power/pwrseq/pwrseq_emmc.c b/drivers/power/pwrseq/pwrseq_emmc.c >> index a0583ed46d7f..a68ac9a68e04 100644 >> --- a/drivers/power/pwrseq/pwrseq_emmc.c >> +++ b/drivers/power/pwrseq/pwrseq_emmc.c >> @@ -22,7 +22,7 @@ >> #include >> > > I don't think this header inclusion is needed. At least I didn't see anything > defined there that's used in this driver. This also applies to pwrseq_simple. > > I think you could remove those in another preparatory patches before the move. > > Reviewed-by: Javier Martinez Canillas Good catch, thanks. BR, Krzysztof