From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758573AbcEFLdG (ORCPT ); Fri, 6 May 2016 07:33:06 -0400 Received: from mga03.intel.com ([134.134.136.65]:11478 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757294AbcEFLdD (ORCPT ); Fri, 6 May 2016 07:33:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,587,1455004800"; d="scan'208";a="697745626" Subject: Re: [PATCH 0/6] perf script: export sampled callchains to database To: Chris Phlipot , jolsa@kernel.org, acme@kernel.org, peterz@infradead.org, mingo@redhat.com References: <1461831551-12213-1-git-send-email-cphlipot0@gmail.com> Cc: linux-kernel@vger.kernel.org From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <572C7FF6.1040603@intel.com> Date: Fri, 6 May 2016 14:28:54 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461831551-12213-1-git-send-email-cphlipot0@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/04/16 11:19, Chris Phlipot wrote: > This patch set contains a set of changes to allow the export of sampled > callchains, and to associate them with samples, via the Python db export > API and export-to-postgresql.py script. > > Call path information is currently only available in the database when > call/return info is available, but not when doing normal sampling. These > changes make this information available for normal sampling runs as well. > > Patches 2-6 are required to make this information available in the > database. > > Patch 1 is needed to fix an existing issue where callchains are > processed incorrectly which can cause the other patches to export > incorrect call paths for a small percentage of samples > (depending on the workload). > > Chris Phlipot (6): > perf tools: fix incorrect ordering of callchain entries > perf tools: refractor code to move call path handling out of > thread-stack > perf script: enable db export to output sampled callchains > perf script: add call path id to exported sample in db export > perf script: expose usage of the callchain db export via the python > api > perf script: update export-to-postgresql to support callchain export > > tools/perf/scripts/python/export-to-postgresql.py | 47 ++++--- > tools/perf/util/Build | 1 + > tools/perf/util/call-path.c | 122 ++++++++++++++++++ > tools/perf/util/call-path.h | 77 ++++++++++++ > tools/perf/util/db-export.c | 89 +++++++++++++ > tools/perf/util/db-export.h | 3 + > tools/perf/util/machine.c | 56 ++++++--- > .../util/scripting-engines/trace-event-python.c | 36 +++++- > tools/perf/util/thread-stack.c | 139 +-------------------- > tools/perf/util/thread-stack.h | 31 ++--- > 10 files changed, 408 insertions(+), 193 deletions(-) > create mode 100644 tools/perf/util/call-path.c > create mode 100644 tools/perf/util/call-path.h > You should have put the version number (V2 in this case) in the email subject and briefly documented what had changed from version to version. e.g. like here http://marc.info/?l=linux-kernel&m=146172371214423 Nevertheless: Jiri Acked patch 1 and I have Acked patches 2 - 5 although some minor changes are needed to patch 3.