From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758367AbcEFOOH (ORCPT ); Fri, 6 May 2016 10:14:07 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:50384 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758054AbcEFOOF (ORCPT ); Fri, 6 May 2016 10:14:05 -0400 X-AuditID: cbfec7f4-f796c6d000001486-bc-572ca6a8bc55 Subject: Re: [PATCH] ARM: dts: exynos: Add MFC memory banks for Peach boards To: Javier Martinez Canillas References: <1461871311-18344-1-git-send-email-javier@osg.samsung.com> <572CA2F3.4050407@samsung.com> <23883a5f-bfed-9474-51a7-14271b6c391f@osg.samsung.com> Cc: linux-kernel@vger.kernel.org, Russell King , Kukjin Kim , devicetree@vger.kernel.org, Kumar Gala , Ian Campbell , linux-samsung-soc@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <572CA6A7.1040102@samsung.com> Date: Fri, 06 May 2016 16:13:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-version: 1.0 In-reply-to: <23883a5f-bfed-9474-51a7-14271b6c391f@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42I5/e/4Nd0Vy3TCDS7PN7GYf+Qcq0X/m4Ws FuderWS0ePN2DZPF6xeGFv2PXzNbbHp8jdXi8q45bBYzzu9jsrh9mddi6fWLTBYTpq9lsWjd e4Tdgddjzbw1jB4tzT1sHpf7epk8Vi7/wuaxaVUnm8fmJfUeW/rvsnv0bVnF6PF5k1wAZxSX TUpqTmZZapG+XQJXxpeFe5kLZklUPP3UyNbA+Ey4i5GTQ0LAROLzum3sELaYxIV769lAbCGB pYwSW2+bQNjPGCUu3ODsYuTgEBbwkXh1xwYkLCJgKvFr7QtWiJKbjBKzLht1MXJxMAtMYJaY uXY7WIJNwFhi8/IlYDN5BbQktt6fzQxiswioSmxZc54FxBYViJBYve4aM0SNoMSPyffA4pwC zhJ/fqxlA9nLLKAncf+iFkiYWUBeYvOat8wTGAVmIemYhVA1C0nVAkbmVYyiqaXJBcVJ6bmG esWJucWleel6yfm5mxgh0fNlB+PiY1aHGAU4GJV4eDNOaocLsSaWFVfmHmKU4GBWEuFtXaQT LsSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC6YklqdmpqQWpRTBZJg5OqQbG7havw/zP llkxpu5Od7L33h+9T/UWY+3ymj9LJAztmR6fu+w44W+ouZqH5eqTB3+6+F0ovvbEVZanbX5+ b+qKKdMlPsQYZ4hkmnmaC9XOtjs/6/69r/O3/euc3/S4XeLPm9C3XpLf3bonxU2I8J59+0Lh 626/lcLt9g9tw9ik/b7JOs84JjdHiaU4I9FQi7moOBEALuMG0ZoCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2016 04:12 PM, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 05/06/2016 09:58 AM, Krzysztof Kozlowski wrote: >> On 05/06/2016 03:44 PM, Javier Martinez Canillas wrote: >>> Hello Krzysztof, >>> >>> On 04/28/2016 03:21 PM, Javier Martinez Canillas wrote: >>>> The MFC nodes with the memory regions reserved for memory allocations >>>> are missing in the Exynos5420 Peach Pit and Exynos5800 Peach Pi DTS. >>>> >>>> This causes the s5p-mfc driver probe to fail with the following error: >>>> >>>> [ 4.140647] s5p_mfc_alloc_memdevs:1072: Failed to declare coherent memory for MFC device >>>> [ 4.216163] s5p-mfc: probe of 11000000.codec failed with error -12 >>>> >>>> Add the missing nodes so the driver probes and the {en,de}coder video >>>> nodes are registered correctly: >>>> >>>> [ 4.096277] s5p-mfc 11000000.codec: decoder registered as /dev/video4 >>>> [ 4.102282] s5p-mfc 11000000.codec: encoder registered as /dev/video5 >>>> >>>> Signed-off-by: Javier Martinez Canillas >>>> >>>> --- >>>> >>>> arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++ >>>> arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +++++ >>>> 2 files changed, 10 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >>>> index b644858231b6..f9d2e4f1a0e0 100644 >>>> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >>>> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >>>> @@ -694,6 +694,11 @@ >>>> status = "okay"; >>>> }; >>>> >>>> +&mfc { >>>> + samsung,mfc-r = <0x43000000 0x800000>; >>>> + samsung,mfc-l = <0x51000000 0x800000>; >>>> +}; >>>> + >>>> &mmc_0 { >>>> status = "okay"; >>>> num-slots = <1>; >>>> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >>>> index 6ba9aec15485..62ceb89e073f 100644 >>>> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >>>> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >>>> @@ -669,6 +669,11 @@ >>>> status = "okay"; >>>> }; >>>> >>>> +&mfc { >>>> + samsung,mfc-r = <0x43000000 0x800000>; >>>> + samsung,mfc-l = <0x51000000 0x800000>; >>>> +}; >>>> + >>>> &mmc_0 { >>>> status = "okay"; >>>> num-slots = <1>; >>>> >>> >>> Any comments about this patch? >> >> What is up with the rush now (a week for ping)? As I understand, this > > Sorry about that... I should had waited for more time for the ping indeed. > I just thought the patch was trivial and you usually answer within days. > >> was broken for very long time on these boards (since adding DT support >> in 2012?). >> > > Yes, that's correct. And in fact even the s5p-mfc driver is currently > not working in mainline. But I posted some fixes and will post more > patches from other people today to get it working. So I thought that > would be nice to have this in since one of my test machines is a Peach. Okay, no problem. I have few more not-so-critical fixes. Queued for earliest possible release. Best regards, Krzysztof