From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758284AbcEFOcw (ORCPT <rfc822;w@1wt.eu>);
	Fri, 6 May 2016 10:32:52 -0400
Received: from foss.arm.com ([217.140.101.70]:56424 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1757430AbcEFOcv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Fri, 6 May 2016 10:32:51 -0400
Subject: Re: [PATCH] coresight: Handle build path error
To: Mathieu Poirier <mathieu.poirier@linaro.org>
References: <1462358484-9342-1-git-send-email-suzuki.poulose@arm.com>
 <CANLsYkwEG-4U+hvdVNHQxoH_WuZvD_pYwDC6NSBOok9o5swNoA@mail.gmail.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: Suzuki K Poulose <Suzuki.Poulose@arm.com>
Message-ID: <572CAB10.7060103@arm.com>
Date: Fri, 6 May 2016 15:32:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <CANLsYkwEG-4U+hvdVNHQxoH_WuZvD_pYwDC6NSBOok9o5swNoA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 06/05/16 15:26, Mathieu Poirier wrote:
> On 4 May 2016 at 04:41, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
>> Enabling a component via sysfs (echo 1 > enable_source), would
>> trigger building a path from the enabled sources to the sink.
>> If there is an error in the process (e.g, sink not enabled or
>> the device (CPU corresponding to ETM) is not online), we never report
>> failure, except for leaving a message in the dmesg.
>>
>> Do proper error checking for the build path and return the error.
>>
>> Before:
>>   $ echo 0 > /sys/devices/system/cpu/cpu2/online
>>   $ echo 1 > /sys/devices/cs_etm/cpu2/enable_source
>>   $ echo $?
>>   0
>>
>> After:
>>   $ echo 0 > /sys/devices/system/cpu/cpu2/online
>>   $ echo 1 > /sys/devices/cs_etm/cpu2/enable_source
>>   -bash: echo: write error: No such device or address
>>
>> Cc: Mathie Porier <mathieu.poirier@linaro.org>
>> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
>
> This patch looks good - thanks for the fix.  Due to how late we are in
> the cycle I'd ask Greg to pick it up right away but there is a
> (couple) of typos in my name on the CC line.  Either resend another
> patch with the correct spelling or remove the CC line altogether.

Sorry about that. will resend it fixed.