From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758539AbcEFOnp (ORCPT ); Fri, 6 May 2016 10:43:45 -0400 Received: from foss.arm.com ([217.140.101.70]:56510 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758517AbcEFOnn (ORCPT ); Fri, 6 May 2016 10:43:43 -0400 Subject: Re: [PATCH 0/3] Support MPS2 UART controller To: Paul Gortmaker References: <1461574068-14641-1-git-send-email-vladimir.murzin@arm.com> Cc: "gregkh@linuxfoundation.org" , jslaby@suse.com, Arnd Bergmann , sudeep.holla@arm.com, linux-serial@vger.kernel.org, LKML , "linux-arm-kernel@lists.infradead.org" From: Vladimir Murzin Message-ID: <572CAD8C.5000102@arm.com> Date: Fri, 6 May 2016 15:43:24 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/05/16 15:31, Paul Gortmaker wrote: > On Mon, Apr 25, 2016 at 4:47 AM, Vladimir Murzin > wrote: >> Hi, >> >> These patches allow to use UART controller found on MPS2 platform. > > Did you intend this driver to support being modular? It has a bool Kconfig > (not tristate) which makes the module_exit dead code. > > If it will always be builtin (with console as primary use case) then you can > see commit 89ebc27427695bfc1e769f1dd99bd243d332ac7a as a possible > update suggestion. Thanks for the pointer, Paul! I'll see how to update the driver and send a patch after next merge window closed. Cheers Vladimir > > P. > -- > >> >> Following [1], please, consider to merge them into tty/serial tree. >> >> [1] https://lkml.org/lkml/2016/4/23/190 >> >> Thanks! >> >> Vladimir Murzin (3): >> dt-bindings: document the MPS2 UART bindings >> serial: mps2-uart: add MPS2 UART driver >> serial: mps2-uart: add support for early console >> >> .../devicetree/bindings/serial/arm,mps2-uart.txt | 19 + >> drivers/tty/serial/Kconfig | 13 + >> drivers/tty/serial/Makefile | 1 + >> drivers/tty/serial/mps2-uart.c | 625 ++++++++++++++++++++ >> include/uapi/linux/serial_core.h | 3 + >> 5 files changed, 661 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/serial/arm,mps2-uart.txt >> create mode 100644 drivers/tty/serial/mps2-uart.c >> >> -- >> 1.7.9.5 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-serial" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >