Re: [PATCH] rpmsg: Make rpmsg sample selectable

Bjorn Andersson
2016-05-06T22:15:08Z

On Fri 06 May 12:25 PDT 2016, Suman Anna wrote:

> Hi Bjorn,
>
> On 05/06/2016 01:06 PM, Bjorn Andersson wrote:
> > rpmsg is not user selectable so the rpmsg sample should not depend on
> > it, as this limits the possibility of compiling the sample client
> > without any other clients.
> >
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> > samples/Kconfig | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/samples/Kconfig b/samples/Kconfig
> > index d54f28c6dc5e..61a251e579ed 100644
> > --- a/samples/Kconfig
> > +++ b/samples/Kconfig
> > @@ -57,7 +57,8 @@ config SAMPLE_KDB
> >
> > config SAMPLE_RPMSG_CLIENT
> > tristate "Build rpmsg client sample -- loadable modules only"
> > - depends on RPMSG && m
> > + select RPMSG
> > + depends on m
>
> Well, I believe this has to do with the fact that we also need to have a
> remoteproc driver enabled, as you cannot have the sample running by
> itself. A remoteproc driver implementing RPMSG would select it, and then
> this sample can be enabled. In fact, I follow this for all rpmsg bus
> drivers.
>

That does sound backwards though. Remoteproc provides means to control
the life cycle of your remote processor and establish (among other
things) the virtio channels for e.g. rpmsg, but it certainly does not
depend on rpmsg.

As far as I can see there's 8 other types of virtio services supported
and I presume we're supposed to select those based on the device's need.

But based on this I believe the correct solution is not to fix the
sample but to make RPMSG selectable in itself.

Regards,
Bjorn