From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758714AbcEFTpN (ORCPT ); Fri, 6 May 2016 15:45:13 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:35426 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758152AbcEFTpH (ORCPT ); Fri, 6 May 2016 15:45:07 -0400 Subject: Re: [PATCH 0/1] devpts: Removing the need for pt_chown To: Greg KH , "Eric W. Biederman" , Linus Torvalds References: <87twixgsnq.fsf@x220.int.ebiederm.org> <87oa95gevf.fsf_-_@x220.int.ebiederm.org> <87mvoo8h3d.fsf@x220.int.ebiederm.org> <87fuug5i6r.fsf_-_@x220.int.ebiederm.org> <874mabt3df.fsf_-_@x220.int.ebiederm.org> <20160506193547.GA30024@kroah.com> Cc: "H. Peter Anvin" , Andy Lutomirski , security@debian.org, "security@kernel.org" , Al Viro , "security@ubuntu.com >> security" , Serge Hallyn , Willy Tarreau , Aurelien Jarno , One Thousand Gnomes , Jann Horn , Linux Kernel Mailing List , Jiri Slaby , Florian Weimer , Konstantin Khlebnikov From: Peter Hurley Message-ID: <572CF43D.2020708@hurleysoftware.com> Date: Fri, 6 May 2016 12:45:01 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160506193547.GA30024@kroah.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/06/2016 12:35 PM, Greg KH wrote: > On Fri, May 06, 2016 at 02:04:12PM -0500, Eric W. Biederman wrote: >> >> Greg, >> >> Could you please apply the following patch to tty-next so it can be >> merged into 4.7-rc1. >> >> We have had a long series of discussions and in the last iteration we >> finally converged on a set of semantics that does not break userspace >> and also makes the code simpler. > > Did everyone agree? I didn't think so, but the thread got long and > messy. And then Linus did some work on this as well. > > How does this play with what Linus proposed? I think only portions of > his original changes are merged, and there are still outstanding parts, > right? Linus committed his proposed pty changes which sits in -rc6 and not in tty-next (which is based on -rc5): commit 8ead9dd54716d1e05e129959f702fcc1786f82b4 Author: Linus Torvalds Date: Mon Apr 25 20:04:08 2016 -0700 devpts: more pty driver interface cleanups This is more prep-work for the upcoming pty changes. Still just code cleanup with no actual semantic changes. This removes a bunch pointless complexity by just having the slave pty side remember the dentry associated with the devpts slave rather than the inode. That allows us to remove all the "look up the dentry" code for when we want to remove it again. .... Linus's changes look good to me and I've been running them cherry-picked on my private tty-next testing tree since. When Greg picks up -rc6 (not sure he was going to do that pre-merge window?), I'd also like to push the devpts_mutex locking down into fs/devpts/inode.c, but I'd be willing to do that later, if it's going to get in the way. Regards, Peter Hurley