From: "René Nyffenegger" <mail@renenyffenegger.ch>
To: Andy Lutomirski <luto@amacapital.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Josh Triplett <josh@joshtriplett.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
Zach Brown <zab@redhat.com>, Milosz Tanski <milosz@adfin.com>,
Arnd Bergmann <arnd@arndb.de>,
Linux API <linux-api@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Use pid_t instead of int
Date: Mon, 9 May 2016 06:15:46 +0200 [thread overview]
Message-ID: <57300EF2.7030303@renenyffenegger.ch> (raw)
In-Reply-To: <CALCETrVyT6R6mYnVuv9vqmeCC7_TB2KZPCqfcmMyLvjbZPs+Ag@mail.gmail.com>
Somewhere else, pid_t is a typedef for an int.
Rene
On 09.05.2016 03:25, Andy Lutomirski wrote:
> On Sun, May 8, 2016 at 12:38 PM, René Nyffenegger
> <mail@renenyffenegger.ch> wrote:
>> Use pid_t instead of int in the declarations of sys_kill, sys_tgkill,
>> sys_tkill and sys_rt_sigqueueinfo in include/linux/syscalls.h
>
> The description is no good. *Why* are you changing it?
>
> I checked tgkill and, indeed, tgkill takes pid_t parameters, so this
> fixes an incorrect declaration. I'm wondering why the code compiles
> without warning. Is SYSCALL_DEFINE too lenient for some reason? Or
> is pid_t just defined as int.
>
> --Andy
>
next prev parent reply other threads:[~2016-05-09 4:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-08 19:38 [PATCH] Use pid_t instead of int René Nyffenegger
2016-05-09 1:25 ` Andy Lutomirski
2016-05-09 4:15 ` René Nyffenegger [this message]
2016-05-09 6:36 ` René Nyffenegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57300EF2.7030303@renenyffenegger.ch \
--to=mail@renenyffenegger.ch \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=josh@joshtriplett.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=milosz@adfin.com \
--cc=rostedt@goodmis.org \
--cc=viro@zeniv.linux.org.uk \
--cc=zab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox