From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751167AbcEIEPx (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 May 2016 00:15:53 -0400
Received: from belinda3.kreativmedia.ch ([80.74.158.27]:54822 "EHLO
	belinda3.kreativmedia.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750864AbcEIEPw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 May 2016 00:15:52 -0400
DomainKey-Signature: a=rsa-sha1;  q=dns; c=nofws;
  s=default; d=renenyffenegger.ch;
  b=nZ01phoXSdFn4csHqOnMD1q6SFUTMkCnmky31vT33wqH6Kyv+1FhYMWa1Ck48v36ndzrgs+D2hTJuSp/YuVWkVH6imCdtZ0sB3KXrkrJUi36msGfbiG43OADd32bHjwgbZZaiyie0Ry6YVbMK3LfI50zenVFTD/1yWjKcP82ulk=;
  h=Subject:To:References:Cc:From:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding;
Subject: Re: [PATCH] Use pid_t instead of int
To: Andy Lutomirski <luto@amacapital.net>
References: <572F959A.7090209@renenyffenegger.ch>
 <CALCETrVyT6R6mYnVuv9vqmeCC7_TB2KZPCqfcmMyLvjbZPs+Ag@mail.gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Josh Triplett <josh@joshtriplett.org>,
        Al Viro <viro@zeniv.linux.org.uk>,
        "Steven Rostedt (Red Hat)" <rostedt@goodmis.org>,
        Zach Brown <zab@redhat.com>, Milosz Tanski <milosz@adfin.com>,
        Arnd Bergmann <arnd@arndb.de>, Linux API <linux-api@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From: =?UTF-8?Q?Ren=c3=a9_Nyffenegger?= <mail@renenyffenegger.ch>
Message-ID: <57300EF2.7030303@renenyffenegger.ch>
Date: Mon, 9 May 2016 06:15:46 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.2
MIME-Version: 1.0
In-Reply-To: <CALCETrVyT6R6mYnVuv9vqmeCC7_TB2KZPCqfcmMyLvjbZPs+Ag@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Somewhere else, pid_t is a typedef for an int.

Rene

On 09.05.2016 03:25, Andy Lutomirski wrote:
> On Sun, May 8, 2016 at 12:38 PM, René Nyffenegger
> <mail@renenyffenegger.ch> wrote:
>> Use pid_t instead of int in the declarations of sys_kill, sys_tgkill,
>> sys_tkill and sys_rt_sigqueueinfo in include/linux/syscalls.h
> 
> The description is no good.  *Why* are you changing it?
> 
> I checked tgkill and, indeed, tgkill takes pid_t parameters, so this
> fixes an incorrect declaration.  I'm wondering why the code compiles
> without warning.  Is SYSCALL_DEFINE too lenient for some reason?  Or
> is pid_t just defined as int.
> 
> --Andy
>