From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752224AbcEIM2T (ORCPT ); Mon, 9 May 2016 08:28:19 -0400 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38019 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750998AbcEIM2S (ORCPT ); Mon, 9 May 2016 08:28:18 -0400 Subject: Re: [PATCH V2 3/3] nvmem: imx-ocotp: handling clock To: Peng Fan , shawnguo@kernel.org, maxime.ripard@free-electrons.com References: <1461173177-11930-1-git-send-email-van.freenix@gmail.com> <1461173177-11930-3-git-send-email-van.freenix@gmail.com> Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Srinivas Kandagatla Message-ID: <5730825E.5030101@linaro.org> Date: Mon, 9 May 2016 13:28:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1461173177-11930-3-git-send-email-van.freenix@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the Ping, I totally missed this thread. On 20/04/16 18:26, Peng Fan wrote: > Before access ocotp nvmem area, the clock should be enabled. > Or, `hexdump nvmem` will hang the system. So, use such flow: > " > 1. clock_enable_prepare > 2. read nvmem ocotp area > 3. clock_disable_unprepare > " > > Signed-off-by: Peng Fan > Cc: Srinivas Kandagatla > Cc: Maxime Ripard > Cc: Shawn Guo > --- > > V2: > Follow Fabio's comments, check return value of clk_prepare_enable > > drivers/nvmem/imx-ocotp.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) Changes to the driver looks good to me, Only one comment, As the clock property is now made mandatory, you should update the dt-bindings with this info too. thanks, srini